Skip to content

fix: include strict bound in blocks included for calculating gas premium #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akaladarshi merged 4 commits into from
Apr 2, 2026
+7 −5
Merged

fix: include strict bound in blocks included for calculating gas premium #6849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ef5b12
include max gas history limit in blocks for calculating gas premium
akaladarshi Apr 2, 2026
9352106
update commnet and include changelog
akaladarshi Apr 2, 2026
f582ca4
address comment
akaladarshi Apr 2, 2026
e6ce922
Merge branch 'main' into akaladarshi/fix-gas-premium-cal
akaladarshi Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@

- [#6817](https://github.com/ChainSafe/forest/pull/6817): Fixed `StateSearchMsg` to return null instead of error when not found to match Lotus behaviour.

- [#6849](https://github.com/ChainSafe/forest/pull/6849): Included strict bound in blocks included for calculating gas premium `GasEstimateGasPremium`.

## Forest v0.32.4 "Mild Inconvenience"

This is a non-mandatory release for all node operators. It enables F3 finality resolution on ETH v1 RPC methods.
Expand Down
10 changes: 5 additions & 5 deletions src/rpc/methods/gas.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ use rand_distr::{Distribution, Normal};
use std::ops::Add;

const MIN_GAS_PREMIUM: f64 = 100000.0;
// constant taken from here <https://github.com/filecoin-project/lotus/blob/v1.35.1/node/impl/gasutils/gasutils.go#L33>
const MAX_GAS_HISTORY: u64 = 128;

/// Estimate the fee cap
pub enum GasEstimateFeeCap {}
Expand Down Expand Up @@ -106,12 +108,10 @@ struct GasMeta {

pub async fn estimate_gas_premium<DB: Blockstore>(
ctx: &Ctx<DB>,
mut nblocksincl: u64,
nblocksincl: u64,
ApiTipsetKey(ts_key): &ApiTipsetKey,
) -> Result<TokenAmount, ServerError> {
if nblocksincl == 0 {
nblocksincl = 1;
}
let nblocksincl = nblocksincl.clamp(1, MAX_GAS_HISTORY);

let mut prices: Vec<GasMeta> = Vec::new();
let mut blocks = 0;
Expand Down Expand Up @@ -163,7 +163,7 @@ pub async fn estimate_gas_premium<DB: Blockstore>(
Ok(premium)
}

// logic taken from here <https://github.com/filecoin-project/lotus/blob/v1.34.3/node/impl/gasutils/gasutils.go#L302>
// logic taken from here <https://github.com/filecoin-project/lotus/blob/v1.35.1/node/impl/gasutils/gasutils.go#L309>
fn compute_gas_premium(mut prices: Vec<GasMeta>, blocks: u64) -> TokenAmount {
prices.sort_by(|a, b| b.price.cmp(&a.price));

Expand Down
Loading