chore: read lock for keystore sign

[LesnyRumcajs]

Summary of changes

Changes introduced in this pull request:

• follow up of fix: remove duplicate code in wallet key management #6853 - signing shouldn't require exclusive lock. This should significantly speed up concurrent signing of messages.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

• I have read and agree to the CONTRIBUTING document.
• I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

• Bug Fixes
  • Improved efficiency of keystore access during message signing operations, reducing unnecessary locking and potential contention in the message pool.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5b089006-2afc-492f-890d-72811aa9188d

📥 Commits

Reviewing files that changed from the base of the PR and between 733c7fe and c4a9825.

📒 Files selected for processing (1)

• src/rpc/methods/mpool.rs

---

Walkthrough

The MpoolPushMessage::handle method in the mpool RPC service was updated to access the keystore in read mode instead of write mode when locating the signing key. The change affects only the keystore access pattern without altering downstream logic.

Changes

Cohort / File(s)	Summary
Keystore Access Mode src/rpc/methods/mpool.rs	Changed keystore access from write mode to read mode when locating the signing key in MpoolPushMessage::handle.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

• akaladarshi
• hanabi1224

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: switching keystore access from write lock to read lock during signing operations in MpoolPushMessage::handle.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch read-wallet-keystore

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch read-wallet-keystore

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (733c7fe) to head (c4a9825).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/rpc/methods/mpool.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
src/rpc/methods/mpool.rs	5.10% <0.00%> (ø)

... and 12 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733c7fe...c4a9825. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.