fix: use i64 instead of u64 in limit exceed error to avoid conversion

[akaladarshi]

Summary of changes

Changes introduced in this pull request:

• uses i64 instead of u64 to avoid casting

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

• I have read and agree to the CONTRIBUTING document.
• I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

• Refactor
  • Improved internal type consistency in error handling for block range validation.

[coderabbitai]

Walkthrough

This pull request changes the block range limit error handling in Ethereum RPC methods from unsigned 64-bit (u64) to signed 64-bit (i64) integers. The EthErrors::BlockRangeExceeded variant and its associated limit_exceeded constructor are updated accordingly, with call sites adjusted to pass native types directly.

Changes

Cohort / File(s)	Summary
Error Definition and Type Signature Update src/rpc/methods/eth/errors.rs	Changed EthErrors::BlockRangeExceeded fields from u64 to i64 for max and given, and updated limit_exceeded() method signature to accept i64 parameters instead of u64.
Error Handler Call Sites src/rpc/methods/eth.rs, src/rpc/methods/eth/filter/mod.rs	Removed explicit as u64 casts from limit_exceeded() invocations, now passing ChainEpoch-typed values and deltas directly without type conversion.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• fix: error when block range exceeds in eth filter and logs #6856: Directly related modifications to the same Ethereum RPC error handling code affecting EthErrors::BlockRangeExceeded and limit_exceeded constructor across eth.rs and filter/mod.rs.

Suggested labels

RPC

Suggested reviewers

• sudo-shashank
• hanabi1224

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing u64 with i64 in the limit exceeded error to avoid type conversions across the codebase.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch akaladarshi/fix-limit-exceeded-err

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch akaladarshi/fix-limit-exceeded-err

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/rpc/methods/eth/errors.rs (1)

46-50: Add a doc comment to limit_exceeded.

This helper is now the single entry point for the signed range error, so a short note about the expected units/semantics would make future call sites clearer. As per coding guidelines "Document public functions and structs with doc comments".

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/rpc/methods/eth/errors.rs` around lines 46 - 50, Add a doc comment to the
public helper function limit_exceeded describing its purpose and the
semantics/units of its parameters and returned error: state that
limit_exceeded(max_block_range: i64, given: i64) constructs a BlockRangeExceeded
error where both parameters are signed i64 representing a block-range size
(number of blocks in the requested range, not absolute block numbers), clarify
whether the range is inclusive/exclusive if relevant, and note that the message
uses these counts; attach the comment directly above the limit_exceeded function
so callers of limit_exceeded and users of the BlockRangeExceeded variant
understand the expected units and behavior.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/rpc/methods/eth/errors.rs`:
- Around line 46-50: Add a doc comment to the public helper function
limit_exceeded describing its purpose and the semantics/units of its parameters
and returned error: state that limit_exceeded(max_block_range: i64, given: i64)
constructs a BlockRangeExceeded error where both parameters are signed i64
representing a block-range size (number of blocks in the requested range, not
absolute block numbers), clarify whether the range is inclusive/exclusive if
relevant, and note that the message uses these counts; attach the comment
directly above the limit_exceeded function so callers of limit_exceeded and
users of the BlockRangeExceeded variant understand the expected units and
behavior.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2f3674a8-15a3-4cec-9472-42154771823b

📥 Commits

Reviewing files that changed from the base of the PR and between 4cfb27b and 28c608a.

📒 Files selected for processing (3)

• src/rpc/methods/eth.rs
• src/rpc/methods/eth/errors.rs
• src/rpc/methods/eth/filter/mod.rs

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.02%. Comparing base (19d1045) to head (28c608a).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/rpc/methods/eth.rs	0.00%	1 Missing ⚠️
src/rpc/methods/eth/filter/mod.rs	66.66%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
src/rpc/methods/eth/errors.rs	69.38% <100.00%> (ø)
src/rpc/methods/eth.rs	65.46% <0.00%> (ø)
src/rpc/methods/eth/filter/mod.rs	88.33% <66.66%> (ø)

... and 21 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cfb27b...28c608a. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.