Skip to content

chore(deps): bump rand#6896

Merged
akaladarshi merged 1 commit intomainfrom
hm/bump-rand
Apr 13, 2026
Merged

chore(deps): bump rand#6896
akaladarshi merged 1 commit intomainfrom
hm/bump-rand

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Apr 13, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated project configuration settings

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 13, 2026

Walkthrough

An additional Rust advisory (RUSTSEC-2026-0097) is added to the deny.toml file's [advisories] ignore list with an inline comment documenting the unsoundness issue in rand when using a custom logger via rand::rng().

Changes

Cohort / File(s) Summary
Configuration
deny.toml
Added RUSTSEC-2026-0097 to the advisories ignore list with a comment noting unsoundness in rand for custom logger usage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

dependencies, rust

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(deps): bump rand' is directly related to the changeset, which adds an advisory ignore entry for a rand-related vulnerability (RUSTSEC-2026-0097) as part of bumping the rand dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/bump-rand
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/bump-rand

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review April 13, 2026 04:35
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 13, 2026 04:35
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team April 13, 2026 04:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.10%. Comparing base (b0c5e23) to head (baf7526).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c5e23...baf7526. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@deny.toml`:
- Line 9: The deny.toml entry for RUSTSEC-2026-0097 was added but Cargo.toml
still pins rand = "0.8", so either upgrade rand to a patched version or add a
justification comment; choose one: (A) Bump rand in Cargo.toml to "0.10.1" (or
later), run cargo update to refresh lockfiles and ensure no breakage in
functions/modules using rand (search for uses of rand::Rng, thread_rng, etc.),
or (B) Keep rand = "0.8" and update the deny.toml comment next to
"RUSTSEC-2026-0097" explaining the risky pattern is not present (state that this
codebase does not call rand::rng() nor implement a custom Logger trait and
instead uses tracing-subscriber), mirroring other ignored-advisory
justifications so reviewers can validate the exception.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c200807b-6d89-442f-817f-5008a0f992bf

📥 Commits

Reviewing files that changed from the base of the PR and between b0c5e23 and baf7526.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • deny.toml

Comment thread deny.toml
@akaladarshi akaladarshi added this pull request to the merge queue Apr 13, 2026
@hanabi1224 hanabi1224 linked an issue Apr 13, 2026 that may be closed by this pull request
Merged via the queue into main with commit b7d0075 Apr 13, 2026
46 checks passed
@akaladarshi akaladarshi deleted the hm/bump-rand branch April 13, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants