Merged
Conversation
LesnyRumcajs
requested review from
akaladarshi and
sudo-shashank
and removed request for
a team
Contributor
WalkthroughThis PR adds GitHub Actions linting infrastructure via a new actionlint configuration and workflow, improves shell safety in existing workflows through consistent variable quoting, removes the Curio devnet Docker Compose setup and related scripts, updates Python linting to use explicit CLI tools instead of a composite action, and adds a new Mise task for actionlint integration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.github/workflows/python-lint.yml (1)
35-38: Consider using the shared lint entrypoint for CI/local parity.Using
mise lint(or the repo’s shared lint task) here would reduce drift between local checks and CI over time.Based on learnings: Run linters with
mise lintbefore submitting code.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/python-lint.yml around lines 35 - 38, The workflow currently runs separate steps "Run black" and "Run flake8" invoking `black --check scripts/` and `flake8 scripts/`; replace these with a single CI step that calls the repository's shared lint entrypoint (`mise lint`) so CI matches local checks, e.g., remove/replace the "Run black" and "Run flake8" steps with one step that runs `mise lint` (ensuring the step name reflects linting and that the command exits non‑zero on failures to preserve current behavior)..github/workflows/actions-lint.yml (1)
15-18: Consider narrowing themise.tomlpath trigger (optional).The workflow triggers on any change to
mise.toml, but only thelint:actionstask definition is relevant. This means unrelated mise.toml changes (e.g., adding a new Rust test task) will trigger this workflow unnecessarily.This is a minor efficiency consideration and acceptable as-is since the workflow is lightweight.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/actions-lint.yml around lines 15 - 18, The workflow currently triggers on any change to "mise.toml" via the paths block, causing unrelated mise.toml edits to run this lint workflow; update the paths in the paths: section (the "paths" block referencing "mise.toml") to either remove "mise.toml" or narrow it to a dedicated config file used only by the lint:actions task (e.g., move the lint-specific config into a separate file like mise.actions.toml and reference that), and ensure any references to the lint task/config (the lint:actions task definition) are updated accordingly so only relevant edits trigger the workflow.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/actions-lint.yml:
- Around line 15-18: The workflow currently triggers on any change to
"mise.toml" via the paths block, causing unrelated mise.toml edits to run this
lint workflow; update the paths in the paths: section (the "paths" block
referencing "mise.toml") to either remove "mise.toml" or narrow it to a
dedicated config file used only by the lint:actions task (e.g., move the
lint-specific config into a separate file like mise.actions.toml and reference
that), and ensure any references to the lint task/config (the lint:actions task
definition) are updated accordingly so only relevant edits trigger the workflow.
In @.github/workflows/python-lint.yml:
- Around line 35-38: The workflow currently runs separate steps "Run black" and
"Run flake8" invoking `black --check scripts/` and `flake8 scripts/`; replace
these with a single CI step that calls the repository's shared lint entrypoint
(`mise lint`) so CI matches local checks, e.g., remove/replace the "Run black"
and "Run flake8" steps with one step that runs `mise lint` (ensuring the step
name reflects linting and that the command exits non‑zero on failures to
preserve current behavior).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 65d27062-9681-4505-8df9-223b41d4ab30
📒 Files selected for processing (27)
.github/actionlint.yaml.github/workflows/actions-lint.yml.github/workflows/cargo-advisories.yml.github/workflows/cargo-publish-dry-run.yml.github/workflows/checkpoints.yml.github/workflows/coverage.yml.github/workflows/curio-devnet-publish.yml.github/workflows/docker.yml.github/workflows/dockerfile-check.yml.github/workflows/forest.yml.github/workflows/python-lint.yml.github/workflows/release.yml.github/workflows/release_dispatch.yml.github/workflows/rpc-parity-report.yml.github/workflows/rpc-parity.yml.github/workflows/rust-lint.yml.github/workflows/snapshot-parity.ymlmise.tomlscripts/devnet-curio/.envscripts/devnet-curio/README.mdscripts/devnet-curio/curio.dockerfilescripts/devnet-curio/curio.envscripts/devnet-curio/docker-compose.ymlscripts/devnet-curio/forest_config.toml.tplscripts/devnet-curio/lotus-miner.envscripts/devnet-curio/lotus.envscripts/devnet-curio/run_curio.sh
💤 Files with no reviewable changes (10)
- scripts/devnet-curio/curio.env
- scripts/devnet-curio/lotus-miner.env
- scripts/devnet-curio/.env
- scripts/devnet-curio/README.md
- scripts/devnet-curio/lotus.env
- scripts/devnet-curio/forest_config.toml.tpl
- scripts/devnet-curio/curio.dockerfile
- scripts/devnet-curio/docker-compose.yml
- .github/workflows/curio-devnet-publish.yml
- scripts/devnet-curio/run_curio.sh
sudo-shashank
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
SC2086andSC2129from shellcheck)Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Removed Features
Chores