Skip to content

chore: reset butterflynet for nv28#6947

Merged
hanabi1224 merged 4 commits intomainfrom
nv28-butterflynet
Apr 21, 2026
Merged

chore: reset butterflynet for nv28#6947
hanabi1224 merged 4 commits intomainfrom
nv28-butterflynet

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Apr 21, 2026

Summary of changes

CI checks(Not yet hitting NV28 upgrade epoch):
https://github.com/ChainSafe/forest/actions/runs/24709319066/job/72269829122

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores

    • Updated Butterflynet genesis to NetworkVersion V27 with new genesis snapshot references and URLs.
    • Switched bootstrap to DNS-based resolution for improved peer discovery.
    • Consolidated actor bundle manifests to v18.0.0-rc1 and updated related bundle/manifest entries.
    • Consolidated migration schedule into a single FireHorse migration entry.
    • Adjusted CI install profile invocation to change install behavior.
  • Tests

    • Relaxed a test comparison to ignore surrounding whitespace in generated manifest checks.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 31d9814d-af39-4e06-8bb5-a66e6de29849

📥 Commits

Reviewing files that changed from the base of the PR and between 09c530c and b8e1a86.

📒 Files selected for processing (2)
  • build/manifest.json
  • src/networks/actors_bundle.rs
✅ Files skipped from review due to trivial changes (1)
  • build/manifest.json

Walkthrough

Updates butterflynet network metadata and migration wiring (switches actor bundles to v18.0.0-rc1, bumps genesis network version V24→V27, sets FireHorse (nv28) migration at height 960), replaces bootstrap peer addresses with a DNS bootstrap, and adjusts CI to run mise ... --slim quick.

Changes

Cohort / File(s) Summary
CI
\.github/workflows/butterflynet.yml
Changed mise install invocation to use the --slim quick profile.
Bootstrap addresses
build/bootstrap/butterflynet
Replaced two hardcoded peer multiaddrs with a single DNS-based bootstrap multiaddress (/dnsaddr/bootstrap.butterfly.fildev.network).
Manifests / Bundles
build/manifest.json, src/networks/actors_bundle.rs
Removed older v15/v16 bundle entries, added/updated v18.0.0-rc1 bundle and updated bundle/actor manifest CIDs.
Network config (butterflynet)
src/networks/butterflynet/mod.rs
Bumped GENESIS_NETWORK_VERSION V24→V27, replaced genesis CAR CID and snapshot URLs, removed per-height bundle CIDs for several upgrades, and set FireHorse at height 960 with v18.0.0-rc1.
Migration wiring & tests
src/state_migration/mod.rs, tests/cmd_state_migration_tests.rs
Replaced Teep (nv25) and GoldenWeek (nv27) migration entries with a single FireHorse (nv28) migration mapping; updated test to trim JSON before comparison.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
  • sudo-shashank
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: reset butterflynet for nv28' accurately reflects the main purpose of the changeset, which updates the butterflynet network configuration to support NV28 across multiple files.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nv28-butterflynet
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch nv28-butterflynet

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 force-pushed the nv28-butterflynet branch 3 times, most recently from 0a44e5f to 28a4dd3 Compare April 21, 2026 07:08
@hanabi1224 hanabi1224 marked this pull request as ready for review April 21, 2026 07:17
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 21, 2026 07:17
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and sudo-shashank and removed request for a team April 21, 2026 07:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.92%. Comparing base (462e824) to head (b8e1a86).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/networks/butterflynet/mod.rs 75.00% 2 Missing ⚠️
src/state_migration/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/networks/actors_bundle.rs 90.26% <100.00%> (-0.05%) ⬇️
src/state_migration/mod.rs 80.89% <0.00%> (+1.77%) ⬆️
src/networks/butterflynet/mod.rs 70.93% <75.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462e824...b8e1a86. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/networks/actors_bundle.rs Outdated
Comment thread src/networks/actors_bundle.rs
LesnyRumcajs
LesnyRumcajs previously approved these changes Apr 21, 2026
@hanabi1224 hanabi1224 enabled auto-merge April 21, 2026 08:16
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
build/manifest.json (1)

1249-1250: Add a consistency check for the duplicated butterflynet bundle metadata.

This butterflynet/v18.0.0-rc1 tuple is now maintained both here and in the ACTOR_BUNDLES table in src/networks/actors_bundle.rs. The values match in this PR, but the next reset only needs one side to drift for runtime lookup to diverge or hit the downstream .expect("bundle must be defined") path. A small test that asserts build/manifest.json stays in sync with ACTOR_BUNDLES would make these network bumps much safer.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@build/manifest.json` around lines 1249 - 1250, Add a unit/integration test
that asserts the bundle tuple in build/manifest.json stays in sync with the
ACTOR_BUNDLES table defined in src/networks/actors_bundle.rs: read the manifest
entry for the "butterflynet" key (and its "version" and "bundle_cid" values) and
compare them against the corresponding entry in the ACTOR_BUNDLES constant (or
map) exported from actors_bundle.rs; fail the test if the keys, version string
(e.g., "v18.0.0-rc1") or bundle CID diverge so CI will catch any future drift
between build/manifest.json and ACTOR_BUNDLES.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@build/manifest.json`:
- Around line 1249-1250: Add a unit/integration test that asserts the bundle
tuple in build/manifest.json stays in sync with the ACTOR_BUNDLES table defined
in src/networks/actors_bundle.rs: read the manifest entry for the "butterflynet"
key (and its "version" and "bundle_cid" values) and compare them against the
corresponding entry in the ACTOR_BUNDLES constant (or map) exported from
actors_bundle.rs; fail the test if the keys, version string (e.g.,
"v18.0.0-rc1") or bundle CID diverge so CI will catch any future drift between
build/manifest.json and ACTOR_BUNDLES.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cef91522-7542-486c-aaef-1e8ebeb3da56

📥 Commits

Reviewing files that changed from the base of the PR and between 50e9503 and 271f541.

📒 Files selected for processing (2)
  • build/manifest.json
  • src/networks/actors_bundle.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/networks/actors_bundle.rs

LesnyRumcajs
LesnyRumcajs previously approved these changes Apr 21, 2026
@hanabi1224 hanabi1224 added this pull request to the merge queue Apr 21, 2026
@hanabi1224 hanabi1224 removed this pull request from the merge queue due to a manual request Apr 21, 2026
@hanabi1224 hanabi1224 enabled auto-merge April 21, 2026 09:21
@hanabi1224 hanabi1224 added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 799007a Apr 21, 2026
59 of 61 checks passed
@hanabi1224 hanabi1224 deleted the nv28-butterflynet branch April 21, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants