Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
WalkthroughUpdates butterflynet network metadata and migration wiring (switches actor bundles to v18.0.0-rc1, bumps genesis network version V24→V27, sets FireHorse (nv28) migration at height 960), replaces bootstrap peer addresses with a DNS bootstrap, and adjusts CI to run Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
0a44e5f to
28a4dd3
Compare
28a4dd3 to
50e9503
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
build/manifest.json (1)
1249-1250: Add a consistency check for the duplicated butterflynet bundle metadata.This
butterflynet/v18.0.0-rc1tuple is now maintained both here and in theACTOR_BUNDLEStable insrc/networks/actors_bundle.rs. The values match in this PR, but the next reset only needs one side to drift for runtime lookup to diverge or hit the downstream.expect("bundle must be defined")path. A small test that assertsbuild/manifest.jsonstays in sync withACTOR_BUNDLESwould make these network bumps much safer.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@build/manifest.json` around lines 1249 - 1250, Add a unit/integration test that asserts the bundle tuple in build/manifest.json stays in sync with the ACTOR_BUNDLES table defined in src/networks/actors_bundle.rs: read the manifest entry for the "butterflynet" key (and its "version" and "bundle_cid" values) and compare them against the corresponding entry in the ACTOR_BUNDLES constant (or map) exported from actors_bundle.rs; fail the test if the keys, version string (e.g., "v18.0.0-rc1") or bundle CID diverge so CI will catch any future drift between build/manifest.json and ACTOR_BUNDLES.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@build/manifest.json`:
- Around line 1249-1250: Add a unit/integration test that asserts the bundle
tuple in build/manifest.json stays in sync with the ACTOR_BUNDLES table defined
in src/networks/actors_bundle.rs: read the manifest entry for the "butterflynet"
key (and its "version" and "bundle_cid" values) and compare them against the
corresponding entry in the ACTOR_BUNDLES constant (or map) exported from
actors_bundle.rs; fail the test if the keys, version string (e.g.,
"v18.0.0-rc1") or bundle CID diverge so CI will catch any future drift between
build/manifest.json and ACTOR_BUNDLES.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: cef91522-7542-486c-aaef-1e8ebeb3da56
📒 Files selected for processing (2)
build/manifest.jsonsrc/networks/actors_bundle.rs
🚧 Files skipped from review as they are similar to previous changes (1)
- src/networks/actors_bundle.rs
72fc502 to
09c530c
Compare
Summary of changes
CI checks(Not yet hitting NV28 upgrade epoch):
https://github.com/ChainSafe/forest/actions/runs/24709319066/job/72269829122
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
Chores
Tests