Skip to content

fix(ci): do not update custom Lotus image#6964

Merged
hanabi1224 merged 1 commit intomainfrom
hm/do-not-update-custom-lotus-image
Apr 23, 2026
Merged

fix(ci): do not update custom Lotus image#6964
hanabi1224 merged 1 commit intomainfrom
hm/do-not-update-custom-lotus-image

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Apr 23, 2026

Summary of changes

To mute #6958

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Improved Lotus version bump workflow precision by refining pattern matching for environment configuration updates across test and devnet systems.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Walkthrough

The Lotus API version bump CI workflow's sed pattern for updating LOTUS_IMAGE entries is narrowed from a generic wildcard match to specifically target filecoin.* patterns across four environment files, while preserving existing tag appending logic.

Changes

Cohort / File(s) Summary
Lotus API Version Bump Workflow
.github/workflows/lotus-api-bump.yml
Modified sed replacement patterns for LOTUS_IMAGE entries from generic LOTUS_IMAGE=.* match to specific LOTUS_IMAGE=filecoin.* match across ./scripts/tests/api_compare/.env, ./scripts/tests/bootstrapper/.env, ./scripts/tests/snapshot_parity/.env, and ./scripts/devnet/.env files. Tag appending logic ($TAG-calibnet and $TAG-2k) remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

RPC

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: modifying CI workflow to prevent updating custom Lotus image by constraining the sed pattern match.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/do-not-update-custom-lotus-image
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/do-not-update-custom-lotus-image

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review April 23, 2026 10:34
@hanabi1224 hanabi1224 requested a review from a team as a code owner April 23, 2026 10:34
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team April 23, 2026 10:34
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/lotus-api-bump.yml (1)

29-29: Line 29 is currently a silent no-op for devnet; make intent explicit.

Given scripts/devnet/.env:1 is LOTUS_IMAGE=ghcr.io/chainsafe/lotus-devnet:..., this replacement never matches. If devnet should stay custom, prefer removing this line (or guarding it with an explicit check/comment) to avoid future confusion.

♻️ Suggested cleanup
-            sed -i "s/\(LOTUS_IMAGE=filecoin.*\):.*/\1:$TAG-2k/" ./scripts/devnet/.env
+            # Intentionally do not bump scripts/devnet/.env here:
+            # devnet uses a custom image (ghcr.io/chainsafe/lotus-devnet).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/lotus-api-bump.yml at line 29, The sed command that
updates LOTUS_IMAGE is a silent no-op against scripts/devnet/.env because the
file contains a custom ghcr.io image; update the workflow to make intent
explicit by either removing the sed line entirely if devnet images must remain
custom, or guard it with an explicit check that the current LOTUS_IMAGE matches
the expected filecoin pattern before running the replacement (i.e., check the
first line of scripts/devnet/.env and only run the sed replacement if it matches
the filecoin regex), and add a clarifying comment so future readers know why
devnet is skipped or updated; reference the sed invocation in
.github/workflows/lotus-api-bump.yml and the scripts/devnet/.env first-line
content when applying the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/lotus-api-bump.yml:
- Line 29: The sed command that updates LOTUS_IMAGE is a silent no-op against
scripts/devnet/.env because the file contains a custom ghcr.io image; update the
workflow to make intent explicit by either removing the sed line entirely if
devnet images must remain custom, or guard it with an explicit check that the
current LOTUS_IMAGE matches the expected filecoin pattern before running the
replacement (i.e., check the first line of scripts/devnet/.env and only run the
sed replacement if it matches the filecoin regex), and add a clarifying comment
so future readers know why devnet is skipped or updated; reference the sed
invocation in .github/workflows/lotus-api-bump.yml and the scripts/devnet/.env
first-line content when applying the change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 697c25b9-927e-4875-a1c8-64badefd5ab3

📥 Commits

Reviewing files that changed from the base of the PR and between 2b734d8 and b6860d3.

📒 Files selected for processing (1)
  • .github/workflows/lotus-api-bump.yml

@hanabi1224 hanabi1224 enabled auto-merge April 23, 2026 10:47
@hanabi1224 hanabi1224 added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 605a179 Apr 23, 2026
37 of 40 checks passed
@hanabi1224 hanabi1224 deleted the hm/do-not-update-custom-lotus-image branch April 23, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants