fix(ci): do not update custom Lotus image#6964
Conversation
WalkthroughThe Lotus API version bump CI workflow's Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/lotus-api-bump.yml (1)
29-29: Line 29 is currently a silent no-op for devnet; make intent explicit.Given
scripts/devnet/.env:1isLOTUS_IMAGE=ghcr.io/chainsafe/lotus-devnet:..., this replacement never matches. If devnet should stay custom, prefer removing this line (or guarding it with an explicit check/comment) to avoid future confusion.♻️ Suggested cleanup
- sed -i "s/\(LOTUS_IMAGE=filecoin.*\):.*/\1:$TAG-2k/" ./scripts/devnet/.env + # Intentionally do not bump scripts/devnet/.env here: + # devnet uses a custom image (ghcr.io/chainsafe/lotus-devnet).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/lotus-api-bump.yml at line 29, The sed command that updates LOTUS_IMAGE is a silent no-op against scripts/devnet/.env because the file contains a custom ghcr.io image; update the workflow to make intent explicit by either removing the sed line entirely if devnet images must remain custom, or guard it with an explicit check that the current LOTUS_IMAGE matches the expected filecoin pattern before running the replacement (i.e., check the first line of scripts/devnet/.env and only run the sed replacement if it matches the filecoin regex), and add a clarifying comment so future readers know why devnet is skipped or updated; reference the sed invocation in .github/workflows/lotus-api-bump.yml and the scripts/devnet/.env first-line content when applying the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/lotus-api-bump.yml:
- Line 29: The sed command that updates LOTUS_IMAGE is a silent no-op against
scripts/devnet/.env because the file contains a custom ghcr.io image; update the
workflow to make intent explicit by either removing the sed line entirely if
devnet images must remain custom, or guard it with an explicit check that the
current LOTUS_IMAGE matches the expected filecoin pattern before running the
replacement (i.e., check the first line of scripts/devnet/.env and only run the
sed replacement if it matches the filecoin regex), and add a clarifying comment
so future readers know why devnet is skipped or updated; reference the sed
invocation in .github/workflows/lotus-api-bump.yml and the scripts/devnet/.env
first-line content when applying the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 697c25b9-927e-4875-a1c8-64badefd5ab3
📒 Files selected for processing (1)
.github/workflows/lotus-api-bump.yml
Summary of changes
To mute #6958
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit