chore: drop custom lints

[LesnyRumcajs]

Summary of changes

Changes introduced in this pull request:

• the custom lint is flaky and introduces tons of dependencies for checking... TODOs that we rarely introduce (part of review and delegation to 🐰 ) and some minor test nits. Dropped it completely to ease maintenance burden, dependency tree and, probably, marginally compilation times. Plus, less flakiness.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

• I have read and agree to the CONTRIBUTING document.
• I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

• Tests

  • Removed the custom linting test framework and its associated validation rules and unit tests.
  • Removed the specialized test profile override for the lint binary.

• Chores

  • Removed development-only dependencies used by the removed testing infrastructure.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5d7ccbb2-4fe0-4eae-aaf5-af86cf58c5fe

📥 Commits

Reviewing files that changed from the base of the PR and between a94c860 and 72c2ebc.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• .config/nextest.toml
• Cargo.toml
• tests/lint.rs
• tests/lints/mod.rs

💤 Files with no reviewable changes (4)

• .config/nextest.toml
• tests/lints/mod.rs
• Cargo.toml
• tests/lint.rs

---

Walkthrough

Removes the project's custom test-only linting infrastructure by deleting the lint test harness and lints module, and removes associated dev-dependencies from Cargo.toml; also drops a nextest profile override for the lint binary.

Changes

Cohort / File(s)	Summary
Cargo manifest Cargo.toml	Removed dev-dependencies used only by the test linting infrastructure: ariadne, cargo_metadata, glob, proc-macro2 (with span-locations), ra_ap_syntax, regex-automata, and syn (no-default-features).
Lint test harness tests/lint.rs	Deleted the custom lint test runner, including fn lint(), LintRunner, source file caching, span/offset helpers, AST-based lint invocation, comment-linter logic, and its unit tests.
Test-only lints tests/lints/mod.rs	Deleted the Lint trait, Violation struct, concrete linters (NoTestsWithReturn, SpecializedAssertions), shared run/assert helpers, and associated unit tests.
Test configuration .config/nextest.toml	Removed the binary(lint) nextest override (the custom slow-timeout profile for the lint binary).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• chore: remove redundant cbor4ii entry from dev deps #6899 — also removes entries from [dev-dependencies] in Cargo.toml, indicating a similar cleanup of test/dev-only crates.

Suggested reviewers

• sudo-shashank
• akaladarshi

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: drop custom lints' accurately and concisely summarizes the main change: removing the project's custom linting infrastructure and related dependencies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch drop-custom-lints

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch drop-custom-lints

---

_{Review rate limit: 3/5 reviews remaining, refill in 14 minutes and 44 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.12%. Comparing base (6d1789f) to head (72c2ebc).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fac3b...72c2ebc. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.