Skip to content

Greg/refactor#3

Merged
Mikerah merged 8 commits intomasterfrom
greg/refactor
Jul 20, 2018
Merged

Greg/refactor#3
Mikerah merged 8 commits intomasterfrom
greg/refactor

Conversation

@GregTheGreek
Copy link
Copy Markdown
Member

@GregTheGreek GregTheGreek commented Jul 20, 2018

I think its important that we merge this in even though it is a WIP.

It addresss a few things with the .gitignore adds mocha & chai, basic tests for the bitfield file (WIP) and fixed Bitfield.hasVoted() to correctly return a boolean and not an integer (0,1). I also cleaned up the exports within the bitflied file to follow proper node convention.

@Mikerah Mikerah merged commit 5e5e7f3 into master Jul 20, 2018
@GregTheGreek GregTheGreek deleted the greg/refactor branch July 20, 2018 18:12
wemeetagain pushed a commit that referenced this pull request Sep 7, 2019
Merge from Chainsafe master
mpetrunic added a commit that referenced this pull request May 8, 2020
mpetrunic added a commit that referenced this pull request Jun 16, 2021
lodekeeper referenced this pull request in lodekeeper/lodestar Feb 3, 2026
- Update @vekexasia/bigint-buffer2 to ^1.0.5 which fixes Bun runtime issues
- Add minimumReleaseAgeExclude for bigint-buffer2 (v1.0.5 released today)
- Re-enable bun CI workflow (was commented out due to #3 issue)

Closes #3 on vekexasia/bigint-swissknife
Related: ChainSafe#8789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants