fix(docs): allow core-js postinstall scripts under pnpm v11#9356
Merged
nflaig merged 1 commit intoMay 11, 2026
Conversation
After the pnpm v11 upgrade (ChainSafe#9299), the "Deploy docs" workflow fails at `cd docs && pnpm install` with: ERR_PNPM_IGNORED_BUILDS Ignored build scripts: core-js-pure@3.36.0, core-js@3.36.0 pnpm v11 defaults `strict-dep-builds=true`, so any transitive dep with a postinstall script that isn't explicitly allowed (or denied) in `allowBuilds` causes install to exit 1. The root `pnpm-workspace.yaml` already declares `core-js: true` in its `allowBuilds` map, but `docs/` is a separate pnpm project (it has its own `pnpm-lock.yaml` and its own `pnpm-workspace.yaml`) and didn't inherit that decision. Docusaurus pulls in both `core-js` and `core-js-pure` transitively. Add the matching entries to `docs/pnpm-workspace.yaml` to align with root behavior. Verified locally with pnpm v11.0.0 from `docs/`: install now resolves 1189 packages and exits 0 with no ERR_PNPM_IGNORED_BUILDS. Refs CI failure on commit 59c0680 (run 25682774486 job 75434691391). 🤖 Generated with AI assistance
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the docs/pnpm-workspace.yaml file to include core-js and core-js-pure in the allowBuilds configuration. The reviewer suggests setting these values to false instead of true to improve installation performance and security, as these post-install scripts are primarily used for informational messages rather than functional build steps.
wemeetagain
approved these changes
May 11, 2026
nflaig
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the pnpm v11 upgrade (#9299), the Deploy docs workflow fails at the
cd docs && pnpm installstep with:pnpm v11 defaults
strict-dep-builds=true, so any transitive dependency with a postinstall script that isn't explicitly allowed (or denied) inallowBuildsfails the install with exit 1.The root
pnpm-workspace.yamlalready declarescore-js: truein itsallowBuildsmap, butdocs/is a separate pnpm project (it has its ownpnpm-lock.yamland its ownpnpm-workspace.yaml) and didn't inherit that decision. Docusaurus pulls in bothcore-jsandcore-js-puretransitively, so the docs install needs the same allow entries.This PR adds the matching entries to
docs/pnpm-workspace.yaml:Verification
Reproduced locally on a fresh worktree at the upstream
unstableHEAD with Node 24 + pnpm 11.0.0:cd docs && pnpm installexits 1 with theERR_PNPM_IGNORED_BUILDSerror (matches CI run 25682774486).cd docs && pnpm installresolves 1189 packages and exits 0 with no error.Test plan
Deploy docsworkflow succeeds against this branch.AI Assistance Disclosure
Deploy docsrun, reproduction of the install error under pnpm 11.0.0, identification of theallowBuildsmechanism mirroring the rootpnpm-workspace.yaml, and authoring of the one-file patch. All changes were reviewed before commit.🤖 Generated with AI assistance