-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Add LinkPool provider for e2e tests on Windows #4869
Conversation
|
This pull request introduces 1 alert when merging bede706 into 832271a - view on LGTM.com new alerts:
|
Pull Request Test Coverage Report for Build 2081921988
💛 - Coveralls |
|
Addressed syntax error |
|
This pull request introduces 1 alert when merging 9631e15 into 832271a - view on LGTM.com new alerts:
|
|
Should we add something like this to address comments from LGTM bot? log(web3.currentProvider) |
|
@0xayanami our internal team members have access to Infura keys in github, for triggering e2e windows tests |
Fix windows e2e test
|
@jdevcs Replaced with LinkPool provider to address your concerns https://medium.com/linkpool/release-of-public-ethereum-rpcs-f5dd57455d2e |
|
This pull request introduces 1 alert when merging 7dca99e into d46d922 - view on LGTM.com new alerts:
|
Address comment
|
This pull request introduces 1 alert when merging 8368cbc into d46d922 - view on LGTM.com new alerts:
|
avkos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. just need to update the branch
|
@avkos Updated |
|
This pull request introduces 1 alert when merging 3a058c4 into 0913e37 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 85d755b into 63b3cfc - view on LGTM.com new alerts:
|
|
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Description
Add LinkPool provider from https://medium.com/linkpool/release-of-public-ethereum-rpcs-f5dd57455d2e to fix e2e test case for Windows.
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.