Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Mar 18, 2022

Description

Add LinkPool provider from https://medium.com/linkpool/release-of-public-ethereum-rpcs-f5dd57455d2e to fix e2e test case for Windows.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@ghost ghost mentioned this pull request Mar 18, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 1 alert when merging bede706 into 832271a - view on LGTM.com

new alerts:

  • 1 for Syntax error

@coveralls
Copy link

coveralls commented Mar 18, 2022

Pull Request Test Coverage Report for Build 2081921988

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.497%

Totals Coverage Status
Change from base Build 2029198956: 0.0%
Covered Lines: 3238
Relevant Lines: 4102

💛 - Coveralls

@ghost
Copy link
Author

ghost commented Mar 18, 2022

Addressed syntax error

@lgtm-com
Copy link

lgtm-com bot commented Mar 18, 2022

This pull request introduces 1 alert when merging 9631e15 into 832271a - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@ghost
Copy link
Author

ghost commented Mar 18, 2022

Should we add something like this to address comments from LGTM bot?

log(web3.currentProvider)

@jdevcs
Copy link
Contributor

jdevcs commented Mar 21, 2022

@0xayanami our internal team members have access to Infura keys in github, for triggering e2e windows tests

@jdevcs jdevcs added the 1.x 1.0 related issues label Mar 21, 2022
Fix windows e2e test
@ghost ghost changed the title Add alchemy provider for e2e tests on Windows Add LinkPool provider for e2e tests on Windows Mar 31, 2022
@ghost ghost requested a review from jdevcs March 31, 2022 05:03
@ghost
Copy link
Author

ghost commented Mar 31, 2022

@jdevcs Replaced with LinkPool provider to address your concerns https://medium.com/linkpool/release-of-public-ethereum-rpcs-f5dd57455d2e

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2022

This pull request introduces 1 alert when merging 7dca99e into d46d922 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@jdevcs jdevcs requested review from avkos and spacesailor24 March 31, 2022 16:22
@jdevcs jdevcs added the Review Needed Maintainer(s) need to review label Mar 31, 2022
@jdevcs jdevcs requested a review from nikoulai March 31, 2022 16:23
Address comment
@ghost ghost requested a review from jdevcs April 2, 2022 11:33
@lgtm-com
Copy link

lgtm-com bot commented Apr 2, 2022

This pull request introduces 1 alert when merging 8368cbc into d46d922 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just need to update the branch

@ghost
Copy link
Author

ghost commented Apr 5, 2022

@avkos Updated

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request introduces 1 alert when merging 3a058c4 into 0913e37 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 26, 2022

This pull request introduces 1 alert when merging 85d755b into 63b3cfc - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@github-actions
Copy link

This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Jun 26, 2022
@github-actions github-actions bot closed this Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.x 1.0 related issues Review Needed Maintainer(s) need to review Stale Has not received enough activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants