Added bool for event polling to not enfroce people to use websockets. #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated rider plugin. Made Multicall not throw exception if the network doesn't support multicalls.
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
rob1997 and
sneakzttv
rob1997
approved these changes
Oct 31, 2024
kantagara
added
the
ready-to-merge
creeppak
reviewed
Oct 31, 2024
...s/io.chainsafe.web3-unity/Runtime/Scripts/Connection/ServiceAdapters/EventsServiceAdapter.cs
Show resolved
Hide resolved
kantagara
added
ready-to-merge
creeppak
approved these changes
Oct 31, 2024
juans-chainsafe
approved these changes
Oct 31, 2024
Contributor
juans-chainsafe
left a comment
juans-chainsafe
left a comment
There was a problem hiding this comment.
-
Error log appears if multicall is not supported
Web3Exception: Can't use MultiCall. No contract for the active chain is available. -
I can login without websocket with the Force Event Polling checked, otherwise throws error as expected.
rob1997
pushed a commit
that referenced
this pull request
Jan 16, 2025
…#1212) * Added bool for event polling to not enfroce people to use websockets. Updated rider plugin. Made Multicall not throw exception if the network doesn't support multicalls. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit * SampleMain reverted to the original setting. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: kantagara <kantagara@users.noreply.github.com>
sergeypanin1994
pushed a commit
to sergeypanin1994/web3.unity
that referenced
this pull request
Mar 16, 2025
…ChainSafe#1212) * Added bool for event polling to not enfroce people to use websockets. Updated rider plugin. Made Multicall not throw exception if the network doesn't support multicalls. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit * SampleMain reverted to the original setting. * Duplicated Samples [skip ci] * Sync Dependencies - Auto Commit --------- Co-authored-by: kantagara <kantagara@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated rider plugin.
Made Multicall not throw exception if the network doesn't support multicalls.