Lootbox samples for re-usability #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightweight fix
abi encoder issues with gas estimation
Reward menus added Need to deserialize data from receipt for rewards Need to deserialize data from API to keep state for inventory
Dynamic balance fetching
lootbox contracts added with conditionals service adapter updated
login working
canvas scaling updated to be agnostic for different screen ratios. functions condensed to reduce repetition. code cleaned up for readability. debug comments removed.
auto-assign
bot
requested review from
creeppak,
juans-chainsafe,
kantagara and
rob1997
sneakzttv
added
the
ready-to-merge
kantagara
reviewed
Dec 4, 2024
...s/Samples/web3.unity SDK Marketplace/3.0.6/Marketplace Samples/Scripts/UI_MarketplaceItem.cs
Show resolved
Hide resolved
Account update
sneakzttv
added
ready-to-merge
rob1997
requested changes
Dec 5, 2024
src/ChainSafe.Gaming.Lootboxes.Chainlink/Dto/LootboxItemList.cs
Outdated
Show resolved
Hide resolved
...s/Samples/web3.unity SDK Lootboxes/3.0.6/Lootbox Samples/Scripts/LootboxesServicesAdapter.cs
Show resolved
Hide resolved
src/UnitySampleProject/ProjectSettings/EditorBuildSettings.asset
Outdated
Show resolved
Hide resolved
...sets/Samples/web3.unity SDK Lootboxes/3.0.6/Lootbox Samples/Scripts/Managers/EventManager.cs
Outdated
Show resolved
Hide resolved
.../Samples/web3.unity SDK Lootboxes/3.0.6/Lootbox Samples/Scripts/Managers/InventoryManager.cs
Show resolved
Hide resolved
.../Samples/web3.unity SDK Lootboxes/3.0.6/Lootbox Samples/Scripts/Managers/InventoryManager.cs
Outdated
Show resolved
Hide resolved
creeppak
suggested changes
Dec 5, 2024
Contributor
creeppak
left a comment
creeppak
left a comment
There was a problem hiding this comment.
Left some questions. Hope we actually get the 3D scene back, I put a lot of effort into it 🥲
src/ChainSafe.Gaming.Lootboxes.Chainlink/LootboxServiceConfig.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
All changes addressed for now. Re review please <3 |
sneakzttv
added
dependencies
sneakzttv
added
ready-to-merge
rob1997
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered service adapter to allow on-chain contracts to work on any chain and not just a local one.
Altered current UIs for a more straight forward and easy to understand approach.
Added a few more methods to accommodate for error handling during the open process.
Testing:
Run setup batch / shell file.
Create a lootbox here on the gaming dashboard.
Fill lootboxes with rewards from the dashboard collections.
Mint lootboxes to your chose wallet address.
Open the lootbox sample scene from the sample package.
Enter the lootbox contract address into the lootboxes service adapter on the web3 object.
Add the events service adapter to the web3object shown below.
Rewards will be dynamically populated for lootbox claims in the reward menu based on event data.
Inventory items are dynamically populated based on the lootbox contents as everything is indexed.