feat(js): add typed array toArray - #70
Merged
Merged
Conversation
wemeetagain
reviewed
Jul 31, 2026
| } | ||
|
|
||
| /// Sum exactly four bytes copied from a Uint8Array into a Zig array. | ||
| pub fn uint8Array4Sum(data: Uint8Array) !Number { |
Member
There was a problem hiding this comment.
what is this fn for? Did this get committed accidentally?
Member
Author
There was a problem hiding this comment.
nope, it's just an example usage of toArray (like the rest of the fn in this file)
but honestly im not a fan of the entire examples/ dir to begin with but not sure of a better alternative at this time
Member
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
ah, sorry, my sloppy review. I didn't see that this was an example.
wemeetagain
reviewed
Jul 31, 2026
| /// Returns: | ||
| /// 1) `error.LengthMismatch` when the TypedArray length differs from | ||
| /// `len`, or | ||
| /// 2) `error.TypeMismatch` when its element type is wrong. |
Member
There was a problem hiding this comment.
Side note, best for a separate PR: it would be nice to define the error sets for consumer use and use explicit error sets in return types.
wemeetagain
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #69