feat: allow v8 alloc for typed-array#21
Merged
Merged
Conversation
GrapeBaBa
approved these changes
Apr 28, 2026
GrapeBaBa
reviewed
Apr 28, 2026
| /// | ||
| /// Consumers should generally use the concrete aliases provided (e.g., `js.Uint8Array`) | ||
| /// rather than instantiating this factory directly. | ||
| pub fn TypedArray(comptime Element: type, comptime array_type: TypedarrayType) type { |
Contributor
There was a problem hiding this comment.
should we consider add comptime type check since it looks like only support several array_types
Contributor
Author
There was a problem hiding this comment.
We use this struct for shared behavior of the typed arrays, so the new functions added here can be used as js.Uint8Array.alloc() or js.Uint16Array.alloc(). Do not understand what do you mean by further comptime checks.
Contributor
Author
There was a problem hiding this comment.
If needed we can add anytime as a patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alloc(len)to TypedArray for zero-copy construction into V8 memorytoSlice()for direct buffer fillExample