add node display method to chi/hardware.py #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mark-Powers
requested changes
Jun 17, 2025
Contributor
Mark-Powers
left a comment
Mark-Powers
left a comment
There was a problem hiding this comment.
Looks good overall, but could you improve the error handling as mentioned below?
chi/hardware.py
Outdated
| HTML(f"<b>Type:</b> {self.type}", style=style, layout=layout), | ||
| HTML(f"<b>Clock Speed:</b> {self.cpu['clock_speed'] / 1e9:.2f} GHz", style=style, layout=layout), | ||
| HTML(f"<b>RAM:</b> {self.main_memory['humanized_ram_size']}", style=style, layout=layout), | ||
| HTML(f"<b>GPU Model:</b> {self.gpu['gpu_model'] or 'None'}", style=style, layout=layout), |
Contributor
There was a problem hiding this comment.
This doesn't work for me when I use an openrc file from TACC, since not all nodes at TACC have gpu_model and gpu_count set.
Could you update the error handling to better support this? I think something like self.gpu.get("gpu_count", 0) would be good to default to 0. And if gpu_count == 0, don't include gpu_model in the display.
Mark-Powers
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
_ipython_display_method to the Node class so that nodes are displayed automagically in Jupyter as follows: