Skip to content

Eliminate CLI top-level await startup warning and stop preselecting GUI Apps on Linux#21

Merged
ChangeHow merged 4 commits intomainfrom
copilot/install-suitup-dependencies
Mar 20, 2026
Merged

Eliminate CLI top-level await startup warning and stop preselecting GUI Apps on Linux#21
ChangeHow merged 4 commits intomainfrom
copilot/install-suitup-dependencies

Conversation

Copy link
Contributor

Copilot AI commented Mar 20, 2026

  • Inspect the review feedback on repeated zsh checks in the CLI
  • Simplify CLI zsh gating to a single pre-switch check with a generic message
  • Update focused CLI tests for the simplified behavior
  • Run targeted Vitest coverage for CLI and setup flows
  • Run final review and reply to the addressed PR comment

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Copilot AI and others added 2 commits March 20, 2026 07:58
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
src/cli.js Outdated
console.log(getHelpText());
break;
case "setup":
exitIfNotZsh("setup");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你这里有必要一行行都写一遍吗?最前面写一遍不就行了,不在乎标题,不是 zsh 就退出提示一个通用信息就行了 @copilot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按这个方向收敛,src/cli.js 现在改成在进入 switch 前统一做一次通用的 zsh 检查,help 不受影响,不再每个 command 单独写一遍。对应提交:49be73e

截图:https://github.com/user-attachments/assets/8eb3f88c-8fd9-44b5-ad71-7c8c97c269bd

Copilot AI changed the title [WIP] Add install script for Suitup dependencies Eliminate CLI top-level await startup warning and stop preselecting GUI Apps on Linux Mar 20, 2026
Copilot AI requested a review from ChangeHow March 20, 2026 08:01
Co-authored-by: ChangeHow <23733347+ChangeHow@users.noreply.github.com>
@ChangeHow ChangeHow marked this pull request as ready for review March 20, 2026 08:04
@ChangeHow ChangeHow merged commit b9db743 into main Mar 20, 2026
1 check passed
@ChangeHow
Copy link
Owner

@copilot 我更新了代码,这下直接退出了:
chenzihao.house@n37-017-250 ~ % curl -fsSL https://raw.githubusercontent.com/ChangeHow/suitup/main/install.sh | bash
Downloading ChangeHow/suitup@main...
Extracting archive...
Installing suitup dependencies...

added 54 packages in 683ms
Launching suitup inside zsh...
┌ Suit up!

◆ Select setup steps:
│ ◼ Bootstrap (Package manager + Zsh)
│ ◼ Zsh Config Structure (~/.config/zsh/)
│ ◼ Plugin Manager (recommended zinit or skip)
│ ◼ CLI Tools (bat, eza, fzf, fd, zoxide, atuin...)
│ ◻ GUI Apps
│ ◼ Frontend Tools (fnm, pnpm, git-cz)
│ ◼ Shell Aliases (git, eza, fzf shortcuts)
│ ◻ SSH Key
│ ◻ Vim Config
│ ◻ Dock Cleanup

chenzihao.house@n37-017-250 ~ %
重新创建一个 PR 帮我解决这个问题

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants