ci(release): restrict tag trigger to semver-only#5
Merged
Conversation
The previous 'v*' pattern would trigger this workflow on moving
major tags (v1, v2 …) that Action consumers track via
'uses: Changsik00/node-settings@v1'. Re-publishing the same npm
version from a moved major tag would fail noisily ('cannot publish
over existing version'), and the GitHub Release that softprops
creates would shadow the real semver release.
Restrict to 'v[0-9]+.[0-9]+.[0-9]+' so only true releases publish,
and movable major tags can be re-pointed without side effects.
Changsik00
added a commit
that referenced
this pull request
May 17, 2026
Adds the Unreleased entries that pnpm release 1.0.1 will promote into the 1.0.1 section: - The Marketplace listing for action.yml (functionally a re-release of v1.0.0 — Action behaviour unchanged). - The release.yml tag-trigger tightening that landed in PR #5 (semver-only filter, so movable major tags no longer trigger a duplicate npm publish).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
To support the moving major tag convention (
uses: Changsik00/node-settings@v1), we need to push av1tag — but the currentrelease.ymltriggers on anyv*tag.If we push
v1today:release.ymlnpm publishfor version 1.0.0 (already published) → failsFix
Tighten the tag pattern to full semver:
Movable major tags (
v1,v2, …) no longer trigger the publish workflow. True semver tags continue to work exactly as before.Test plan
git push origin v1(after this merges) — should not trigger any workflow run.pnpm release X.Y.Zcontinues to firerelease.ymlnormally.workflow_dispatchre-publish path unchanged.