Skip to content

Conversation

@jacomago
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

Copy link
Contributor

@anderslindho anderslindho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if CF's versioning was decoupled from the rest of the phoebus applications and services, so we could follow semantic versioning (ping @shroffk)

@jacomago jacomago merged commit a1eb2db into ChannelFinder:master Apr 24, 2025
6 checks passed
@shroffk
Copy link
Collaborator

shroffk commented Apr 24, 2025

Broadly I agree...however,
there are some common modules like utility and data representation which do land up connecting the version numbers
we are going to be updating springboot and JDK versions for CF so that would justify moving to 5.0.0 keeping CF in line with Phoebus.

Maybe we keep the major version synchronized and the minor versions can be updated as required by CF releases

@anderslindho
Copy link
Contributor

I see.

we are going to be updating springboot and JDK versions for CF so that would justify moving to 5.0.0 keeping CF in line with Phoebus.

Maybe we keep the major version synchronized and the minor versions can be updated as required by CF releases

I think it would be better if we avoid trying to keep versions in sync, and instead increment the major digit only when there are incompatible API changes, minor when we add functionality in a backwards compatible manner, and patch when we make backward compatible bug fixes. That way it will be easier to work with other consumers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants