0.5 changeable ping interval #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anage traffic for mobile connections) Server/client links are reset after server/client is closed Communicator logic to detect offline case relies on the closed flag Cosmetics
|
Minor bug with setting ping interval is resolved in |
added 3 commits
April 17, 2018 12:26
- backward compatibility of exposed API preserved - symmetric implementation for server and client - fail-fast for server/client builders for WSS not initialized with SSLContext/SSLSocketFactory - More explanatory exception for scheme and configuration mismatch for client than just NPE
WssFactoryBuilder and WssSocketBuilder now expose only the minimum required API
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
============================================
- Coverage 51.09% 48.96% -2.13%
+ Complexity 673 672 -1
============================================
Files 157 160 +3
Lines 2558 2667 +109
Branches 180 191 +11
============================================
- Hits 1307 1306 -1
- Misses 1183 1292 +109
- Partials 68 69 +1 |
|
@sumlin I am trying to avoid to spend double effort making tests for not yet synchronized codebase. I tried to create pull requests in a way to add functionality incrementally to make it easier to merge. Once we are in sync I will migrate tests (which I already have done for standalone parts like utilities). |
TVolden
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.