- 
                Notifications
    
You must be signed in to change notification settings  - Fork 190
 
Propertyconstraintexception is unchecked #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propertyconstraintexception is unchecked #65
Conversation
5268927    to
    e1e566f      
    Compare
  
    
          Codecov Report
 @@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     52.82%   53.46%   +0.63%     
- Complexity      787      812      +25     
============================================
  Files           180      180              
  Lines          3061     3045      -16     
  Branches        221      211      -10     
============================================
+ Hits           1617     1628      +11     
+ Misses         1359     1333      -26     
+ Partials         85       84       -1 | 
    
e1e566f    to
    e7f78cf      
    Compare
  
    | 
           @TVolden The PR is ready for review.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
I'm not a big fan of testing specific text, especially for an exception. It's subject to change and doesn't add allot of value to the test.
Other than that, everything looks fine.
#63