Change SetChargingProfile.req attribute validation according to documentation #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
===========================================
+ Coverage 45.12% 45.2% +0.08%
- Complexity 821 822 +1
===========================================
Files 180 180
Lines 3712 3712
Branches 355 355
===========================================
+ Hits 1675 1678 +3
+ Misses 1949 1948 -1
+ Partials 88 86 -2 |
TVolden
approved these changes
Sep 25, 2018
|
Hi Fabian, You're right. Thanks for your PR. It just merged it 😃 Sincerely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of "6.43. SetChargingProfile.req" states in its description that the connectorId can be "0" to identify the station itself when setting a ChargePointMaxProfile or a TxDefaultProfile the implementation does not allow "0" at the moment. I changed the validation to be able to set such profiles.