Removing jasmine as a package#189
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Jasmine-related dev dependencies from the Angular app and simplifies GitHub Actions caching by dropping actions/setup-node’s built-in npm cache configuration (while keeping explicit actions/cache steps).
Changes:
- Removed
jasmineand@types/jasminefromapp/package.jsonand pruned them fromapp/package-lock.json. - Removed
actions/setup-nodenpm cache settings from CI workflows to avoid redundant caching configuration.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
app/package.json |
Drops Jasmine dev dependencies now that tests run via Jest. |
app/package-lock.json |
Removes Jasmine packages and related transitive entries from the lockfile. |
.github/workflows/test.yml |
Removes setup-node cache configuration while retaining explicit actions/cache usage. |
.github/workflows/auto-approve.yml |
Removes setup-node cache configuration (but caching/install behavior needs tweaks). |
.github/workflows/angular-build.yml |
Removes setup-node cache configuration (but caching/install behavior needs tweaks). |
Files not reviewed (1)
- app/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
16
to
20
| - name: Set up node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: 'app/.nvmrc' | ||
| cache: 'npm' | ||
| cache-dependency-path: 'app/package-lock.json' | ||
| - name: Cache npm |
Comment on lines
17
to
21
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version-file: 'app/.nvmrc' | ||
| cache: 'npm' | ||
| cache-dependency-path: 'app/package-lock.json' | ||
| - name: Cache npm | ||
| uses: actions/cache@v5 |
Comment on lines
47
to
51
| - name: Set up node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| cache-dependency-path: 'app/package-lock.json' | ||
| - name: Cache npm |
Comment on lines
22
to
26
| - name: Set up node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| cache-dependency-path: 'app/package-lock.json' | ||
| - name: Cache npm |
Comment on lines
22
to
26
| - name: Set up node | ||
| uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| cache: 'npm' | ||
| cache-dependency-path: 'app/package-lock.json' | ||
| - name: Cache npm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing jasmine as a package as well as uncecessary use of cache