Fix NRE in watchdog

[Clayell]

Consistent NRE would show up when loading into the space center scene, as Settings could be null

[EXC 19:58:21.615] NullReferenceException: Object reference not set to an instance of an object
	AdvancedPQSTools.WatchDogs.Update () (at <9132a6a28a214f5b8e0a2d965abd7ef8>:0)
	UnityEngine.DebugLogHandler:LogException(Exception, Object)
	ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
	UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

Sidenote:
What is this supposed to be doing?

foreach (ConfigNode node in GameDatabase.Instance.GetConfigNodes("ADVANCEDPQSTOOLS"))
      Settings = node;

If it's supposed to be finding the first node, why not use FirstOrDefault?

[Phantomical]

foreach (ConfigNode node in GameDatabase.Instance.GetConfigNodes("ADVANCEDPQSTOOLS"))
      Settings = node;

As a note, that actually seems to be finding the last settings node. Is that intentional?

[Clayell]

I also noticed that, which is why I didn't remove it. Seems to be incredibly fragile behavior if intended.

[ballisticfox]

That appears to be carried over from the original RealSolarSystem source:
https://github.com/KSP-RO/RealSolarSystem/blob/a92a04972f68d48c7f83c24f47ff6aa96ba1a6f4/Source/Watchdogs.cs#L20-L27

[Clayell]

Is anything in this file actually needed for AdvancedPQSTools? It all seems RSS-specific, if it isn't actually useful/needed it would probably be best to remove it.

[ballisticfox]

Is anything in this file actually needed for AdvancedPQSTools? It all seems RSS-specific, if it isn't actually useful/needed it would probably be best to remove it.

From my understanding of what this code does, which is resetting flight states and near clip/far clip plane camera settings in the event of another mod changing something, I don’t see how that is incredibly RSS specific nor unneeded

[Clayell]

I just checked, and AdvancedPQSTools doesn't even contain the config that would make this work.
The equivalent RSS config is here, but AdvancedPQSTools never brought it over.
That file has a comment noting that it is Custom settings for RealSolarSystem. Here is the commit history for those configs:
KSP-RO@079a5f2
KSP-RO@3c45a66
KSP-RO@59059ab
I could ask siimav what exactly they mean.

[ballisticfox]

Those are in Sol though? https://github.com/RSS-Reborn/Sol-Configs/blob/main/Sol-Configs/Patches/Sol-RSSConfiguration.cfg

[Clayell]

Ah, so they are.

As a note, that actually seems to be finding the last settings node. Is that intentional?

Should we fix this? I can make it instead look for the ADVANCEDPQSTOOLS node with a ClipPlanes node in it.

[ballisticfox]

Yeah that'd be ideal

[Clayell]

Done, ready for merge