Skip to content

Update minimum required Go version to 1.18#348

Merged
pajlada merged 4 commits intomasterfrom
chore/bump-go-versions
Aug 13, 2022
Merged

Update minimum required Go version to 1.18#348
pajlada merged 4 commits intomasterfrom
chore/bump-go-versions

Conversation

@pajlada
Copy link
Copy Markdown
Member

@pajlada pajlada commented Aug 13, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

@pajlada pajlada changed the title Update Go versions from 1.17 & 1.18 to 1.18 & 1.19 Update minimum required Go version to 1.18 Aug 13, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2022

Codecov Report

Merging #348 (c710e85) into master (9369303) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   48.91%   48.91%           
=======================================
  Files          98       98           
  Lines        3146     3146           
=======================================
  Hits         1539     1539           
  Misses       1565     1565           
  Partials       42       42           
Impacted Files Coverage Δ
internal/resolvers/default/thumbnail_loader.go 27.11% <0.00%> (ø)
internal/resolvers/discord/invite_loader.go 0.00% <0.00%> (ø)
internal/resolvers/oembed/facebook.go 0.00% <0.00%> (ø)
internal/resolvers/supinic/track_loader.go 0.00% <0.00%> (ø)
internal/resolvers/betterttv/emote_loader.go 84.48% <100.00%> (ø)
internal/resolvers/oembed/initialize.go 56.25% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pajlada pajlada merged commit 54bcd62 into master Aug 13, 2022
@pajlada pajlada deleted the chore/bump-go-versions branch August 13, 2022 11:26
@leon-richardt
Copy link
Copy Markdown
Contributor

Shouldn't this have been mentioned as a breaking change in the changelog? At the time of writing, CHANGELOG.md still refers to 1.17 as the minimum supported version.

@pajlada
Copy link
Copy Markdown
Member Author

pajlada commented Oct 4, 2022

Shouldn't this have been mentioned as a breaking change in the changelog? At the time of writing, CHANGELOG.md still refers to 1.17 as the minimum supported version.

Probably yeah, we'll probably move towards just having our readme state that we follow Golang's support scheme (i.e. always supporting the latest 2 releases)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants