Don't initialize youtube resolver if youtube-api-key is empty#556
Merged
pajlada merged 4 commits intoChatterino:masterfrom Nov 21, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #556 +/- ##
==========================================
- Coverage 47.22% 47.13% -0.09%
==========================================
Files 99 99
Lines 3733 3738 +5
==========================================
- Hits 1763 1762 -1
- Misses 1918 1923 +5
- Partials 52 53 +1 ☔ View full report in Codecov by Sentry. |
pajlada
approved these changes
Nov 21, 2023
pajlada
reviewed
Nov 21, 2023
pajlada
approved these changes
Nov 21, 2023
M4tthewDE
deleted the
feature/youtube-api-key-missing-not-handled-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Don't initialize youtube resolver if api key is empty. As far as I can tell from reading the source, the package we are using does not care about the api key being empty and does not return an error.
The test inintialize_test.gofails for me locally, but it passes in CI.That might be worth an investigation?Turns out
google.golang.org/api/youtube/v3automatically pulls in creentials fromGOOGLE_APPLICATION_CREDENTIALS