feat: globally suppress highlight notifications#5629
feat: globally suppress highlight notifications#5629jupjohn wants to merge 14 commits intoChatterino:masterfrom
Conversation
|
Tested the following against 271d57e (pre-rebase) and works as expected: Hotkey usage:
Window context menu checkbox connection:
Window context menu checkbox action:
|
|
Would anyone be against me NOT implementing visual feedback to indicate the state of notification suppression (i.e. show an icon next in the notebook header like stream mode?) It would be nice from a user-perspective, but I'd rather get the core functionality in first. |
jupjohn
force-pushed
the
feature/5628-globally-suppress-notifications
branch
from
271d57e to
582f452
Compare
| {"toggleGlobalNotificationSuppression", | ||
| ActionDefinition{ | ||
| .displayName = "Toggle muting of all notifications", | ||
| .argumentDescription = "[on, off, or toggle. default: toggle]", | ||
| .minCountArguments = 0, | ||
| .maxCountArguments = 1, | ||
| .possibleArguments{{"Toggle", {}}, | ||
| {"Enable notification muting", {"on"}}, | ||
| {"Disable notification muting", {"off"}}}, | ||
| .argumentsPrompt = "New value:", | ||
| .argumentsPromptHover = "Should all highlight notifications be " | ||
| "enabled, disabled, or toggled.", | ||
| }}, |
There was a problem hiding this comment.
Bikeshed: Do we want this as a "negative" option? "Disable notification muting" is (kind-of) a double-negative - you're enabling notifications.
Oh, also: what about live notifications? "toggleGlobalNotificationSuppression" sounds like it would disable everything.
There was a problem hiding this comment.
Good point! Happy to run with "mute notifications" and "unmute notifications" 👍
|
I'll be implementing the visual feedback in this PR as it's not being included in 2.5.2 (discussed on pajlada's stream a while back) |
jupjohn
force-pushed
the
feature/5628-globally-suppress-notifications
branch
from
513e190 to
1319caa
Compare
|
Scuffed GIMP design, how do we feel about this icon when this feature is enabled?
I originally went with a filled red circle, but it's too much IMO. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // do not disturb | ||
| this->doNotDisturbIcon_ = this->addCustomButton(); | ||
| QObject::connect(this->doNotDisturbIcon_, &NotebookButton::leftClicked, | ||
| [this] { |
There was a problem hiding this comment.
warning: lambda capture 'this' is not used [clang-diagnostic-unused-lambda-capture]
| [this] { | |
| [] { |
|
|
||
| // do not disturb | ||
| this->doNotDisturbTitlebarIcon_ = | ||
| this->addTitleBarButton(TitleBarButtonStyle::DoNotDisturb, [this] { |
There was a problem hiding this comment.
warning: lambda capture 'this' is not used [clang-diagnostic-unused-lambda-capture]
| this->addTitleBarButton(TitleBarButtonStyle::DoNotDisturb, [this] { | |
| this->addTitleBarButton(TitleBarButtonStyle::DoNotDisturb, [] { |
On Windows, this is a bad idea. There's almost no space to drag the window when streamer mode is enabled and do-not-disturb is enabled:
|
2 participants
This PR aims to implement global suppression of highlight notifications through a "Do Not Disturb"-like feature. I wanted to get this out of my head before I lost interest in it.
TODO:
Implements #5628.