-
-
Notifications
You must be signed in to change notification settings - Fork 545
fix: don't force 96 dpi #5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: don't force 96 dpi #5802
Conversation
|
Good catch! Linux (Wayland w/ sway), 100% monitorText renders the same, icons render slightly different but only better from what I can tell Linux (Wayland w/ sway), 150% monitorText is aliased differently, but I'm not 100% sure if this is due to screenshots scaling weirdly on sway. When I look at the monitor itself, everything looks very good still. Nothing has changed significantly in size. macOS 200% monitorTab text size, Tab size, and chat text size are all smaller with this change. It's more in line with other texts (text input & chat header). Text still looks sharp. Overall I think this change is fine on macOS, but I could do more thorough testing in settings & menus to see if anything changes there. macOS 100% monitorNot tested yet |
You only showed a screenshot from Chatterino.
The badges in the second screenshot are 18x18 (original size) and in the first, they're 22x22, which is roughly
This is a different issue - it's not the intention of this PR to fix this. |




Setting
AA_Use96Dpiwould fix fonts to a specific pixel/point size (usage in Qt). We want the fonts to scale and use the scale provided by the OS. I only tested this on Windows.Fixes #5411.
Tests
The following tests should be done for each platform and configuration:
Platforms and Setups