Skip to content

Add decision/research item type with options list#5

Open
CheapNud wants to merge 4 commits intomainfrom
d/decision-type
Open

Add decision/research item type with options list#5
CheapNud wants to merge 4 commits intomainfrom
d/decision-type

Conversation

@CheapNud
Copy link
Copy Markdown
Owner

@CheapNud CheapNud commented May 1, 2026

Adds a TaskKind enum (Todo/Decision) and an Options field. EditTaskDialog gets a switch to convert a row into a decision; when active the title relabels to "Question" and an Options textarea appears (one option per line). The list view renders decisions with a help icon prefix and the options as a small bulleted caption beneath the question. Resolving a decision still uses the existing checkbox/Done flag. Includes migration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

🤖 Claude AI Code Review

  1. Summary: Adds a TaskKind enum and Options field to support decision/research items, with corresponding UI changes in the edit dialog and list view, plus an EF Core migration.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean, well-structured feature addition with proper rollback logic in the save handler and consistent use of MudBlazor components.

  3. Issues

🟢 Raw HTML <ul>/<li> used for options list — The options rendering in Tasks.razor uses raw HTML (<ul>, <li>) instead of a MudBlazor component like MudList/MudListItem, which violates the project convention of preferring MudBlazor components over raw HTML.

  1. Verdict: APPROVE

The raw HTML is minor and functional; everything else looks correct — migration is clean, no async violations, proper IDbContextFactory pattern presumably maintained, and the feature is well-contained.


📊 Tokens: 4202 input + 242 output | 💰 Cost: ~$0.0812
Generated by Claude Opus 4.6 via GitHub Actions

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

🤖 Claude AI Code Review

  1. Summary: Adds a TaskKind enum, Options field, and decision/research item UX to the edit dialog and list view, with an EF Core migration.

  2. Code Quality ⭐⭐⭐⭐☆
    Good use of MudBlazor components, proper rollback on save failure, and clean separation of the new feature.

  3. Issues

🔴 Empty migration will not add the new columns: The Up() and Down() methods in 20260502192405_AddDecisionType.cs are completely empty — no AddColumn calls for Kind or Options. The model snapshot was updated, so EF tooling thinks the columns exist, but deploying this migration will leave the database schema out of sync, causing runtime errors on any query touching Kind or Options.

🟢 Raw HTML <ul>/<li> for decision options: The options list uses raw HTML instead of a MudBlazor component (MudList/MudListItem). Minor per project rules.

  1. Verdict: REQUEST CHANGES
  • Fix the migration Up() to actually add the Kind (integer, non-nullable, default 0) and Options (nullable varchar(1000)) columns, and Down() to drop them. Re-scaffold or hand-write the migration body.

📊 Tokens: 4080 input + 328 output | 💰 Cost: ~$0.0858
Generated by Claude Opus 4.6 via GitHub Actions

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

🤖 Claude AI Code Review

  1. Summary: Adds a TaskKind enum and Options field to support decision/research items, with corresponding UI changes in EditTaskDialog and the task list view, plus an EF Core migration.

  2. Code Quality ⭐⭐⭐⭐☆
    Clean, well-structured feature addition with proper rollback logic in the save handler and consistent use of MudBlazor components.

  3. Issues

🟢 Raw HTML <ul>/<li> used for options list — The options rendering in Tasks.razor uses raw HTML instead of MudBlazor components (e.g., MudList/MudListItem), which violates the MudBlazor-preferred rule.

  1. Verdict: APPROVE

The raw HTML for the bulleted list is a minor rule violation but understandable for a compact inline caption style where MudList would be heavier than needed. Everything else looks solid — migration is correct, no async issues, no leaked resources, proper use of IDbContextFactory patterns (presumably from existing code), and the enum default of 0 = Todo ensures backward compatibility with existing rows.


📊 Tokens: 4239 input + 281 output | 💰 Cost: ~$0.0847
Generated by Claude Opus 4.6 via GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant