This repository was archived by the owner on Jun 30, 2025. It is now read-only.
feat: persisted Station ID passed to Zinnia#424
Merged
Conversation
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Apr 23, 2024
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
suggested changes
Apr 24, 2024
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Member
Author
|
@juliangruber @PatrickNercessian I addressed the comments, and the pull request is ready for final review and merging. @juliangruber if we manage to land this PR today, could you please land #414 as well, before publishing a new Station Core release. |
PatrickNercessian
approved these changes
Apr 24, 2024
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
approved these changes
Apr 25, 2024
This was referenced Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the concept of a Station instance ID that's represented as a public key of an Ed25119 keypair.
Generate the keypair on the first start and store it in a state file. Load the keypair from the state file on subsequent starts.
Introduce an optional env var PASSPHRASE allowing operators to specific a passphrase that will be used to encrypt & decrypt the file storing the keypair.
Implement an upgrade path allowing users to start with an empty PASSPHRASE and later upgrade their deployment with a PASSPHRASE string. Station will load the plaintext keypair and encrypt it using the new PASSPHRASE when it detects this situation.
Forward the Station ID to Zinnia via env vars and include it in the telemetry data written to InfluxDB.
Closes #406