Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

feat: exit code 2 when walled failed screening#450

Merged
bajtos merged 2 commits intomainfrom
report-invalid-wallet-address
May 10, 2024
Merged

feat: exit code 2 when walled failed screening#450
bajtos merged 2 commits intomainfrom
report-invalid-wallet-address

Conversation

@bajtos
Copy link
Member

@bajtos bajtos commented May 9, 2024

When the user provides FIL_WALLET_ADDRESS that's rejected by our screening service, return a different exit code to allow Station Desktop to detect this error and apply different error handling.

See https://space-meridian.sentry.io/issues/4996347608/events/7c27f714175449b7b347bbae476151b6/

When the user provides FIL_WALLET_ADDRESS that's rejected by our
screening service, return a different exit code to allow Station Desktop
to detect this error and apply different error handling.

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
@bajtos bajtos requested a review from juliangruber May 9, 2024 06:36
Copy link
Member

@juliangruber juliangruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bajtos bajtos enabled auto-merge (squash) May 10, 2024 14:17
@bajtos bajtos merged commit b5925e1 into main May 10, 2024
@bajtos bajtos deleted the report-invalid-wallet-address branch May 10, 2024 14:19
bajtos added a commit to CheckerNetwork/desktop that referenced this pull request May 10, 2024
See CheckerNetwork/node#450

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos added a commit to CheckerNetwork/desktop that referenced this pull request May 10, 2024
See CheckerNetwork/node#450

Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants