This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Merged
Conversation
bajtos
approved these changes
Mar 22, 2023
Member
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to the HTTP API from #60 #63.
Based on the Zinnia in Filecoin Station ADR, emit events over stdout.
This should be the simplest interface for Station Desktop. We can eventually add an HTTP server for remote access, but now this isn't a requirement and therefore overkill.
I'm happy that the strategy from this PR (as inspired by Zinnia) already should cover everything that Station Desktop will need, effectively closing the whole milestone.
Logs didn't need to be added, as Station will simply call
$ station logs saturn-l2-nodeif it wants to export these.Closes https://github.com/filecoin-station/core/milestone/3
Closes CheckerNetwork/roadmap#14
Closes #60
Closes #63