This repository was archived by the owner on Jan 6, 2026. It is now read-only.
Merged
Conversation
When the storage provider does not advertise HTTP retrieval, but advertises Grapsync retrievals, then let's perform the retrieval check. This was my original intention when I implemented IPNI querying. Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
previously requested changes
Mar 7, 2024
lib/spark.js
Outdated
| stats.indexerResult = indexerResult | ||
|
|
||
| if (indexerResult !== 'OK') return | ||
| if (indexerResult !== 'OK' && indexerResult !== 'HTTP_NOT_ADVERTISED') return |
Member
There was a problem hiding this comment.
Suggested change
| if (indexerResult !== 'OK' && indexerResult !== 'HTTP_NOT_ADVERTISED') return | |
| if (!(indexerResult === 'OK' || indexerResult === 'HTTP_NOT_ADVERTISED')) return |
I find this more understandable: Skip if the indexer result isn't ok or http_not_advertised. Alternatively:
Suggested change
| if (indexerResult !== 'OK' && indexerResult !== 'HTTP_NOT_ADVERTISED') return | |
| if (!['OK', 'HTTP_NOT_ADVERTISED'].includes(indexerResult)) return |
Member
Author
There was a problem hiding this comment.
Makes sense. I decided to extract a named variable to make this even easier to understand.
const providerFound = indexerResult === 'OK' || indexerResult === 'HTTP_NOT_ADVERTISED'
if (!providerFound) returnSigned-off-by: Miroslav Bajtoš <oss@bajtos.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the storage provider does not advertise HTTP retrieval, but advertises Grapsync retrievals, then let's perform the retrieval check.
This was my original intention when I implemented IPNI querying.
I discovered the problem by accident while working on #55. Unfortunately, there is no easy way how to write a reliable automated test for this, as we would need a CID that's guaranteed to have only Graphsync advertised to IPNI.
FWIW, we want to move to testing HTTP retrievals only and drop support for Graphsync (see #46). However, since we are not there yet, I feel this bug is still worth fixing.
Here is a script I used to verify the fix manually. Please not you need to include changes from #55 to be able to reproduce the problem.