Skip to content
This repository was archived by the owner on Jan 7, 2026. It is now read-only.

Remove setScores functionality and delete lib/submit-scores.js#638

Merged
bajtos merged 2 commits intomainfrom
copilot/fix-29a34e60-a5d3-4d19-b6a8-20d549a95fa2
Oct 8, 2025
Merged

Remove setScores functionality and delete lib/submit-scores.js#638
bajtos merged 2 commits intomainfrom
copilot/fix-29a34e60-a5d3-4d19-b6a8-20d549a95fa2

Conversation

Copy link
Contributor

Copilot AI commented Oct 6, 2025

This PR removes all references to the setScores function and deletes the lib/submit-scores.js file as part of cleanup efforts.

Changes

  • Removed the import of setScores from bin/spark-evaluate.js
  • Removed the setScores parameter from the startEvaluate function call in bin/spark-evaluate.js
  • Removed the setScores parameter from the startEvaluate function signature in index.js
  • Deleted lib/submit-scores.js which contained the setScores implementation

Context

The setScores function was used to submit scores to https://spark-rewards.fly.dev/scores but is no longer needed. The file even had a TODO comment indicating tests were never written for it.

Testing

  • Verified all references to setScores and submit-scores have been removed from the codebase
  • Ran npx standard --fix to ensure code formatting is correct
  • All unit tests that don't require external dependencies are passing (78 passing)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.filspark.com
    • Triggering command: node /home/REDACTED/work/spark-evaluate/spark-evaluate/node_modules/.bin/mocha (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Remove all references to setScores, remove the file lib/submit-scores.js and related tests. Run npm test to verify that all tests pass. Run npm run lint:fix to fix formatting.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@bajtos
Copy link
Member

bajtos commented Oct 6, 2025

This is a follow-up for #569

Co-authored-by: bajtos <1140553+bajtos@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove all references to setScores, remove the file lib/submit-scores.js and related tests. Run npm test to verify that all tests pass. Run npm run lint:fix to fix formatting. Remove setScores functionality and delete lib/submit-scores.js Oct 6, 2025
Copilot AI requested a review from bajtos October 6, 2025 11:46
@bajtos bajtos marked this pull request as ready for review October 6, 2025 14:05
@bajtos bajtos merged commit 57c9356 into main Oct 8, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this to ✅ done in CheckerNetwork Oct 8, 2025
@bajtos bajtos deleted the copilot/fix-29a34e60-a5d3-4d19-b6a8-20d549a95fa2 branch October 8, 2025 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: ✅ done

Development

Successfully merging this pull request may close these issues.

3 participants