This repository was archived by the owner on Jan 7, 2026. It is now read-only.
Remove setScores functionality and delete lib/submit-scores.js#638
Merged
Remove setScores functionality and delete lib/submit-scores.js#638
Conversation
Member
|
This is a follow-up for #569 |
Co-authored-by: bajtos <1140553+bajtos@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove all references to
Remove setScores functionality and delete lib/submit-scores.js
Oct 6, 2025
setScores, remove the file lib/submit-scores.js and related tests. Run npm test to verify that all tests pass. Run npm run lint:fix to fix formatting.
bajtos
approved these changes
Oct 6, 2025
juliangruber
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all references to the
setScoresfunction and deletes thelib/submit-scores.jsfile as part of cleanup efforts.Changes
setScoresfrombin/spark-evaluate.jssetScoresparameter from thestartEvaluatefunction call inbin/spark-evaluate.jssetScoresparameter from thestartEvaluatefunction signature inindex.jslib/submit-scores.jswhich contained thesetScoresimplementationContext
The
setScoresfunction was used to submit scores tohttps://spark-rewards.fly.dev/scoresbut is no longer needed. The file even had a TODO comment indicating tests were never written for it.Testing
setScoresandsubmit-scoreshave been removed from the codebasenpx standard --fixto ensure code formatting is correctWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.filspark.comnode /home/REDACTED/work/spark-evaluate/spark-evaluate/node_modules/.bin/mocha(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.