AST-37667 fix test testResultsStructure #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cx-tamar-levi
requested review from
OrShamirCM,
checkmarx-kobi-hagmi and
cx-ben-alvo
cx-pedro-lopes
requested review from
a team,
cx-hugo-machado and
cx-pedro-lopes
and removed request for
a team
Contributor
|
Policy Management Violations
No New Or Fixed Issues Found |
checkmarx-kobi-hagmi
approved these changes
May 16, 2024
OrShamirCM
approved these changes
May 16, 2024
OrShamirCM
reviewed
May 16, 2024
| for (Scan scan : scanList) { | ||
| Results results = wrapper.results(UUID.fromString(scan.getId())); | ||
| if (results != null && results.getResults() != null) { | ||
| Assertions.assertEquals(results.getTotalCount(), results.getResults().size()); |
Contributor
There was a problem hiding this comment.
Dont we want to break the loop but assert not as part of the loop? this way we will not pass the assertion.
Contributor
There was a problem hiding this comment.
casue as it now, it'll assert only if we are in the if. and we want to make sure that the scanned did have results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the test to find a scan with results and don't fail if there is a scan without results