Skip to content

AST-37667 fix test testResultsStructure #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2024
Merged

AST-37667 fix test testResultsStructure #325

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28da15
AST-37667 fix test testResultsStructure
cx-tamar-levi May 16, 2024
b0fe8a6
AST-37667 send agent in test testResultsJson
cx-tamar-levi May 16, 2024
9b1eb8b
Merge branch 'main' into fix/fix_test
cx-tamar-levi May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/test/java/com/checkmarx/ast/ResultTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ void testResultsJSON() throws Exception {
List<Scan> scanList = wrapper.scanList("statuses=Completed");
Assertions.assertTrue(scanList.size() > 0);
String scanId = scanList.get(0).getId();
String results = wrapper.results(UUID.fromString(scanId), ReportFormat.json);
String results = wrapper.results(UUID.fromString(scanId), ReportFormat.json, "java-wrapper");
Assertions.assertTrue(results.length() > 0);
}

Expand All @@ -53,9 +53,13 @@ void testResultsSummaryJSON() throws Exception {
void testResultsStructure() throws Exception {
List<Scan> scanList = wrapper.scanList("statuses=Completed");
Assertions.assertTrue(scanList.size() > 0);
String scanId = scanList.get(0).getId();
Results results = wrapper.results(UUID.fromString(scanId));
Assertions.assertEquals(results.getTotalCount(), results.getResults().size());
for (Scan scan : scanList) {
Results results = wrapper.results(UUID.fromString(scan.getId()));
if (results != null && results.getResults() != null) {
Assertions.assertEquals(results.getTotalCount(), results.getResults().size());
Copy link
Contributor

@OrShamirCM OrShamirCM May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we want to break the loop but assert not as part of the loop? this way we will not pass the assertion.

Copy link
Contributor

@OrShamirCM OrShamirCM May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

casue as it now, it'll assert only if we are in the if. and we want to make sure that the scanned did have results

break;
}
}
}

@Test()
Expand Down