Integration with results#7
Merged
Merged
Conversation
yaelpery
suggested changes
Apr 1, 2020
|
|
||
| func (r *ResultsHTTPWrapper) GetByScanID(scanID string, limit, offset uint64) ([]ResultResponseModel, *ResultError, error) { | ||
| resp, err := getRequestWithLimitAndOffset(r.url+"/scan"+scanID+"/items", limit, offset) | ||
| resp, err := getRequestWithLimitAndOffset(r.url+"/"+scanID+"/items", limit, offset) |
Contributor
There was a problem hiding this comment.
why not use fmt.sprintf() ?
Contributor
Author
There was a problem hiding this comment.
Right. Done
| viper.SetDefault(projectsPath, "projects") | ||
| viper.SetDefault(uploadsPath, "uploads") | ||
| viper.SetDefault(resultsPath, "results") | ||
| viper.SetDefault(resultsPath, "scan") |
Contributor
There was a problem hiding this comment.
results is better, we can mistake the scan for scans in the future.
I guess this is how the treafik sees this but consider changing this back
Contributor
Author
There was a problem hiding this comment.
Nope. it's just the current prefix before results API changes
| if string(scan.Status) == string(requiredStatus) { | ||
| ch <- true | ||
| return | ||
| } else if string(scan.Status) == scansRESTApi.ScanFailed || string(scan.Status) == scansRESTApi.ScanCanceled { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.