Skip to content

change title of metric unit "rpm" to "Revolutions per minute"#202

Closed
perlduck wants to merge 1 commit intoCheckmk:masterfrom
perlduck:miswording-in-unit
Closed

change title of metric unit "rpm" to "Revolutions per minute"#202
perlduck wants to merge 1 commit intoCheckmk:masterfrom
perlduck:miswording-in-unit

Conversation

@perlduck
Copy link
Copy Markdown
Contributor

@perlduck perlduck commented Jun 6, 2020

The "r" in "rpm" neither means "rotations" nor "rounds" but "revolutions".

@perlduck perlduck force-pushed the miswording-in-unit branch from b8e7f9c to 91c711e Compare June 7, 2020 16:03
@perlduck
Copy link
Copy Markdown
Contributor Author

perlduck commented Jun 7, 2020

I force-pushed this branch because I changed the commit message. Sorry for the noise.

@perlduck perlduck changed the title fix "rpm" unit's title to "Revolutions per minute" change title of metric unit "rpm" to "Revolutions per minute" Jun 8, 2020
The "r" in "rpm" neither means "rotations" nor "rounds" but "revolutions".
@perlduck perlduck force-pushed the miswording-in-unit branch from 91c711e to cb050e5 Compare June 8, 2020 10:41
@jherbel
Copy link
Copy Markdown
Contributor

jherbel commented Jun 10, 2020

Hello perlduck,

thank you for this pull request. We will have a closer look at your patch and discuss internally on how and if we can implement it into the official code base.

Internal Ref: CMK-4669

@LarsMichelsen
Copy link
Copy Markdown
Member

Just merged the patch. Thanks for your work!

@perlduck perlduck deleted the miswording-in-unit branch June 12, 2020 13:35
CheckmkCI pushed a commit that referenced this pull request Nov 20, 2025
Change-Id: Ic1b7be6cfece64012f20fb6af6d2d025d9e0775a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants