Skip to content

Drawer Improvements (All Around)#262

Merged
ChefZander merged 34 commits intoChefZander:masterfrom
AbbyRead:drawer-fixes
Mar 4, 2026
Merged

Drawer Improvements (All Around)#262
ChefZander merged 34 commits intoChefZander:masterfrom
AbbyRead:drawer-fixes

Conversation

@AbbyRead
Copy link
Copy Markdown
Contributor

@AbbyRead AbbyRead commented Mar 4, 2026

So there's a bunch of stuff in this:

  • Refactored and move code to more sensible places.
  • Added basic rotation to drawers when using screwdriver.
  • Fixed most of the contents indication visuals.
  • Uses S() for description and info strings to allow for easier localization.
  • Adds Drawer Connectors as a block ("Trim" from the original drawers mod).
  • Allows the player to destroy a drawer even if it has stuff in it.
    • Contents go into the player's inventory directly if possible.
    • Upgrades take priority (in case destroying the drawer was a bad move).
    • If the player has no more room in their inventory, the rest just drops from the drawer (have not tested large amounts dropped... maybe I should... 😬).

AbbyRead added 30 commits March 2, 2026 11:13
@AbbyRead
Simplify license copy (remove repeat text)
54bdde6
@AbbyRead
Replace minetest namespace with core
758deb5
@AbbyRead
Add screwdriver-based rotation to drawers
6903129
@AbbyRead
Clarify license copy
6ce1884
@AbbyRead
Satisfy linter
f122ec0
@AbbyRead
Refactor drawer slot metadata registry
462ba0e
@AbbyRead
Refactor drawer node box definition
dccef27 
I did this manually by figuring it all out from
using a nodebox editor rubenwardy made.  Now we
can modify things if we want, but also it just
kind of gets rid of all those magic numbers.
@AbbyRead
Move visuals functions to visual(s) and rename
0991784
@AbbyRead
Move components to sensible places
b2c9021
@AbbyRead
Try to get drawer connectors working
5c5b0c3
@AbbyRead
Update stubes
5d70e31
@AbbyRead
Merge branch 'drawer-fixes' of https://github.com/AbbyRead/skyblock_zero
6fbdf38 
 into drawer-fixes
@AbbyRead
Fix dumb mistake in call signature
4a505d0
@AbbyRead
Fix drawer connector rendering
271b8e3
@AbbyRead
Add new textures
d901ab5
@AbbyRead
Remove unnecessary use of nodebox for connector
f32da08
@AbbyRead
Refactor for localization support
97d0b04
@AbbyRead
Refactor drawer upgrade template recipe
c4db4bc
@AbbyRead
Refactor drawer recipes
7cc091f
@AbbyRead
Refactor drawer upgrades recipe
b4686f4
@AbbyRead
Fix drawer connector transfer
6e76fd9
@AbbyRead
Refactor Upgrades GUI pane formspecs
0bf4048
@AbbyRead
Remove hotbar vs remainder visual spacing
1213a78
@AbbyRead
Placate stubes
52a4e82
@AbbyRead
Fix contents visual yaw persistence
dae5fed
@AbbyRead
Fix weird mesh/node visuals (mostly)
14b83f1
@AbbyRead
Make animated nodes render like other weird crap
12848af
@AbbyRead
Mess with the sizing of weird node visuals
f6f4df8
@AbbyRead
Improve metal block and default node visuals
86a64fd
@AbbyRead
Let drawers return or drop upgrades and items
4021e3e
@AbbyRead AbbyRead mentioned this pull request Mar 4, 2026
Closed
TheEt1234
TheEt1234 approved these changes Mar 4, 2026
View reviewed changes
mods/drawers/api.lua
Copyright (C) 2016 Mango Tango <mtango688@gmail.com>

Modifications for Skyblock: Zero:
Copyright (C) 2026 Skyblock: Zero Contributors
Copy link
Copy Markdown
Contributor

@TheEt1234 TheEt1234 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(i dont know if copyright works like this, @corpserot is this correct)

@ChefZander ChefZander merged commit 15f0751 into ChefZander:master Mar 4, 2026
@AbbyRead AbbyRead deleted the drawer-fixes branch March 4, 2026 20:13
@AbbyRead AbbyRead restored the drawer-fixes branch March 4, 2026 20:44
AbbyRead pushed a commit to AbbyRead/skyblock_zero that referenced this pull request Mar 9, 2026
@ChefZander
Merge pull request ChefZander#262 from AbbyRead/drawer-fixes
dbf0e87 
Drawer Improvements (All Around)
AbbyRead pushed a commit to AbbyRead/skyblock_zero that referenced this pull request Mar 9, 2026
@ChefZander
Merge pull request ChefZander#262 from AbbyRead/drawer-fixes
2c3d6f3 
Drawer Improvements (All Around)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheEt1234 TheEt1234 TheEt1234 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbbyRead @TheEt1234 @ChefZander