Skip to content

Disallow leaves replacing water source blocks when growing a Colorium Tree#263

Merged
ChefZander merged 3 commits intoChefZander:masterfrom
AbbyRead:colorium-tree-fix
Mar 4, 2026
Merged

Disallow leaves replacing water source blocks when growing a Colorium Tree#263
ChefZander merged 3 commits intoChefZander:masterfrom
AbbyRead:colorium-tree-fix

Conversation

@AbbyRead
Copy link
Copy Markdown
Contributor

@AbbyRead AbbyRead commented Mar 4, 2026

To address a personal gripe explained in issue #254, leaves shouldn't replace water source blocks anymore with this PR. Tested in-game, and it works! Couldn't get any trees to destroy that water no mo'.

(minetest.registered_nodes[node_at_pos.name].buildable_to or node_at_pos.name == leafnode)
(core.registered_nodes[node_at_pos.name].buildable_to or node_at_pos.name == leafnode)
-- Disallow leaves replacing water source blocks when growing a tree
and node_at_pos.name ~= "sbz_resources:water_source"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about other liquids

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about doing those, but I might be biased in a dumb, nostalgic way. I tried escaping a planet core by growing trees out from it through the molten metal.

It probably would be a good idea so as not to screw up people's stone farms too badly. Water seems like the most immediate troll since it can happen sooner to players. But yeah, if you wanna. What's your pleasure?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably would be a good idea so as not to screw up people's stone farms too badly. Water seems like the most immediate troll since it can happen sooner to players. But yeah, if you wanna. What's your pleasure?

Trees are supposed to respect protection

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure about doing those, but I might be biased in a dumb, nostalgic way. I tried escaping a planet core by growing trees out from it through the molten metal.

But sure, i guess that can be kept

@ChefZander ChefZander merged commit 4473a32 into ChefZander:master Mar 4, 2026
@AbbyRead AbbyRead deleted the colorium-tree-fix branch March 4, 2026 20:13
AbbyRead pushed a commit to AbbyRead/skyblock_zero that referenced this pull request Mar 9, 2026
Disallow leaves replacing water source blocks when growing a Colorium Tree
AbbyRead pushed a commit to AbbyRead/skyblock_zero that referenced this pull request Mar 9, 2026
Disallow leaves replacing water source blocks when growing a Colorium Tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants