Sound Design Overhaul: Part 1#269
Merged
ChefZander merged 91 commits intoChefZander:masterfrom Mar 17, 2026
Merged
Conversation
I want to make it clearer and more intentional when you set sounds on nodes and items and things. To do that, I'm taking out the rigmarole that affords defaults that we haven't even consistently used up to this point.
This was frustrating me because here and there I would hear the step sound when punching certain blocks and not know why. I don't want default engine behavior to trigger when we forget to include a sound. Better off having it silent or having it fail loudly until we put in something we legitimately choose.
These are only to taunt me and facilitate troubleshooting.
I tried to make it fade in and have overlap so that it at least sounds like it's looping, even if it isn't, technically.
I didn't end up using them, actually.
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still consider this a work-in-progress, but the more eyes (ears?) we have on it, the more feedback we'll get about what works and what doesn't. Let me know if you need anything else from this. Right now, there's still a lot of missing sounds, but there's at least more here now than there was when I started. :)