Chrisjurich/remove chem db#89
Merged
Merged
Conversation
…convenience function to the test/structure/structure_io/test_pdb_io.py file
shaoqx
requested changes
Oct 15, 2022
Collaborator
shaoqx
left a comment
shaoqx
left a comment
There was a problem hiding this comment.
Nice! Just one minor change is requested.
Changed the formatting of data structures to be more readable and also added comments to prevent yapf from changing these in the future.
Added extra three letter codes for residues back in. Previously added by QZ in science_refactor PR
Changed test for number of three letter amino acid keys back to 29 to accomodate inclusion of extra keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the last traces of the
load_from_db()calls from theenzy_htp.chemical.dbsubmodule. Tests/installation should be possible now.