Skip to content

Improve interaction logic, panne switch, add keymap #15

Merged
ChenMiaoi merged 4 commits intoChenMiaoi:developfrom
zevorn:feat/tui-keymap-header-vim-jumps
Mar 9, 2026
Merged

Improve interaction logic, panne switch, add keymap #15
ChenMiaoi merged 4 commits intoChenMiaoi:developfrom
zevorn:feat/tui-keymap-header-vim-jumps

Conversation

@zevorn
Copy link
Contributor

@zevorn zevorn commented Mar 9, 2026

Optimize the panne selection logic. When an item in the upper-level panne is selected and the Enter key is pressed, the border of the lower-level panne will be highlighted and the content will be refreshed.
Add more key mappings in vim mode, such as gg/G to jump to the beginning/end of a line, qq to exit self.
Add more key mapping in vim mode, such as muber + j/k jump special line.

- add the custom ui.keymap value and keep its navigation fallback aligned with default bindings
- render the active keymap in the header and surface the new option in config help and docs
- add regression coverage for custom keymap loading and header rendering

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7bdc6f3dfd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@zevorn zevorn force-pushed the feat/tui-keymap-header-vim-jumps branch from 7bdc6f3 to 10bfe3f Compare March 9, 2026 15:34
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

❌ Patch coverage is 93.82716% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ui/tui.rs 91.91% 11 Missing ⚠️
src/ui/tui/input.rs 95.69% 4 Missing ⚠️
src/ui/tui/render.rs 96.34% 3 Missing ⚠️
src/ui/tui/config.rs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

zevorn added 3 commits March 10, 2026 00:00
- add gg/G jumps and qq quit chords across the mail and code-browser panes
- scope pending vim chords to the active pane and clear them when modal surfaces take focus
- clamp preview and source scrolling so Shift+G stays render-safe, and document/test the workflow

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- focus the threads pane when Enter opens a mailbox from subscriptions, including cached and syncing paths
- focus the preview pane when Enter opens the selected thread so the mail workflow advances forward
- add regression coverage for subscription and thread Enter transitions plus non-blocking inbox cases

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
- add scoped numeric prefixes for repeated vertical movement on the main page in default/custom and vim keymaps
- clear pending counts when focus changes or modal surfaces take over so prefixes do not leak across interactions
- document the count shortcuts and add TUI regression coverage for counted moves and scope resets

Signed-off-by: Chao Liu <chao.liu.zevorn@gmail.com>
@zevorn zevorn force-pushed the feat/tui-keymap-header-vim-jumps branch from 10bfe3f to b902d13 Compare March 9, 2026 16:02
Copy link
Owner

@ChenMiaoi ChenMiaoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenMiaoi ChenMiaoi merged commit d887ff0 into ChenMiaoi:develop Mar 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants