Skip to content

fix: hide CherryIN manual model add button#16703

Merged
kangfenmao merged 1 commit into
v1from
zhibisora/fix-remove-cherryin-add-model-button
Jul 3, 2026
Merged

fix: hide CherryIN manual model add button#16703
kangfenmao merged 1 commit into
v1from
zhibisora/fix-remove-cherryin-add-model-button

Conversation

@zhibisora

Copy link
Copy Markdown
Collaborator

What this PR does

Before this PR: CherryIN provider settings showed the manual add-model button next to the model list fetch/manage button.

After this PR: CherryIN provider settings hide the manual add-model button while keeping model list fetch/manage available.

Fixes # None

Why we need it and why it was done in this way

The following tradeoffs were made: The change is limited to the provider model list action buttons so CherryIN OAuth and model sync flows remain unchanged.

The following alternatives were considered: Disabling all add actions in the manage model dialog was considered, but the requested scope was only to remove the manual add-model button.

Links to places where the discussion took place: N/A

Breaking changes

None.

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

Testing: pnpm format, pnpm lint, and pnpm test passed. pnpm lint reported an existing React hooks warning in ManageModelsPopup.tsx and exited successfully.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

Hide the manual add-model button for CherryIN providers in model settings.

Signed-off-by: zhibisora <73344387+zhibisora@users.noreply.github.com>
@eeee0717

eeee0717 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

This comment was translated automatically.

Is this change necessary?


Original Content

这个改动是有必要的吗?

@zhibisora

zhibisora commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

This comment was translated automatically.

Is this change necessary?

This was already clarified in the meeting. Users often manually fill in the model thinking it can be used, but in fact the model ID is completely wrong. This brings significant explanation costs and causes users more frustration, thinking the service is unavailable after purchase.
2fe7c3065792dc216f4e2a259619c791


Original Content

This comment was translated automatically.这条评论已被自动翻译。

Is this change necessary?这种改变有必要吗?

Original Content 原创内容
这个改动是有必要的吗?

会议上已经明确。用户经常将模型手动填写进去就以为这个模型可以用了,但事实上模型ID完全是错误的,这带来了较大的解释成本,并且使得用户有更多挫败感,认为服务购买后不可用。
2fe7c3065792dc216f4e2a259619c791

@kangfenmao kangfenmao merged commit da0a11f into v1 Jul 3, 2026
13 of 15 checks passed
@kangfenmao kangfenmao deleted the zhibisora/fix-remove-cherryin-add-model-button branch July 3, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants