Skip to content

Comments

feat(i18n): RTL support#3782

Open
DeJeune wants to merge 17 commits intoCherryHQ:mainfrom
DeJeune:feat/rtl-renderer
Open

feat(i18n): RTL support#3782
DeJeune wants to merge 17 commits intoCherryHQ:mainfrom
DeJeune:feat/rtl-renderer

Conversation

@DeJeune
Copy link
Collaborator

@DeJeune DeJeune commented Mar 22, 2025

#3691

  • Updated language settings to include Arabic (Egypt) as a supported language.
  • Modified locale imports and adjusted language handling in the ConfigManager.
  • Enhanced RTL styles and layout adjustments for better support of right-to-left languages.
  • Removed deprecated dependencies related to RTL processing.
  • Added new translations for Arabic (Egypt) in the localization files.

Pleasurecruise and others added 5 commits March 21, 2025 10:40
- Updated language settings to include Arabic (Egypt) as a supported language.
- Modified locale imports and adjusted language handling in the ConfigManager.
- Enhanced RTL styles and layout adjustments for better support of right-to-left languages.
- Removed deprecated dependencies related to RTL processing.
- Added new translations for Arabic (Egypt) in the localization files.
@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

冲突解决下?然后我测测

@0xfullex 0xfullex added the WIP Indicates that a PR should not merge because it is a work in progress label Apr 2, 2025
@DeJeune
Copy link
Collaborator Author

DeJeune commented Apr 2, 2025 via email

@DeJeune
Copy link
Collaborator Author

DeJeune commented Apr 2, 2025

冲突解决下?然后我测测

可以了,测一下?

@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

冲突解决下?然后我测测

可以了,测一下?

好的,今天我测下

@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

  • windows,右上角标题和关闭操作重叠了
    image

  • minApp,左侧留了空白,应该是之前为了sidebar留的
    image

其他暂时没发现问题

@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

另外,我不清楚RTL使用者的习惯,需要UI也镜像过去吗?还是说只是文字从右到左就行了

@DeJeune
Copy link
Collaborator Author

DeJeune commented Apr 2, 2025

  • windows,右上角标题和关闭操作重叠了
    image
  • minApp,左侧留了空白,应该是之前为了sidebar留的
    image

其他暂时没发现问题

第一个,如果你把系统调成阿拉伯语应该在左上角(所以我就没适配)。然后第二个我改一下

@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

第一个,如果你把系统调成阿拉伯语应该在左上角(所以我就没适配)。然后第二个我改一下

原来如此,我没问题了。

这个merge是不是覆盖了#3702 ?

@0xfullex 0xfullex added needs-review the feature/bug/pr needs a product/development reviewing and removed WIP Indicates that a PR should not merge because it is a work in progress labels Apr 2, 2025
@0xfullex 0xfullex requested review from 0xfullex and kangfenmao April 2, 2025 10:14
@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

然后还有一个问题,这个阿拉伯语言,后边是机器翻译,还是每次需要人工翻译?如果人工的话,难度增加了不少呀

@DeJeune
Copy link
Collaborator Author

DeJeune commented Apr 2, 2025

然后还有一个问题,这个阿拉伯语言,后边是机器翻译,还是每次需要人工翻译?如果人工的话,难度增加了不少呀

也不是人工翻译,我也是用gpt翻译的,可以后面放到自动化流程里面

@DeJeune
Copy link
Collaborator Author

DeJeune commented Apr 2, 2025

第一个,如果你把系统调成阿拉伯语应该在左上角(所以我就没适配)。然后第二个我改一下

原来如此,我没问题了。

这个merge是不是覆盖了#3702 ?

是的

@0xfullex
Copy link
Collaborator

0xfullex commented Apr 2, 2025

也不是人工翻译,我也是用gpt翻译的,可以后面放到自动化流程里面

因为有专门一个目录(i18n/translate)是给机器翻译用的,在自动化流程里,放在那里会更好

@kangfenmao kangfenmao force-pushed the main branch 3 times, most recently from f053212 to 244a42f Compare July 3, 2025 17:15
@0xfullex 0xfullex added Pending On hold due to priority/low, unresolved issues, suboptimal solution or needs more research and removed needs-review the feature/bug/pr needs a product/development reviewing labels Jul 10, 2025
@EurFelux
Copy link
Collaborator

#9025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pending On hold due to priority/low, unresolved issues, suboptimal solution or needs more research

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants