feat(cli): add actor profile surfaces and glossary docs#64
feat(cli): add actor profile surfaces and glossary docs#64go-maple wants to merge 7 commits intoChesterRa:mainfrom
Conversation
Safe split from mixed cli reference state; excludes staged resume/session notes.
Includes resume/session/status reference docs, CLI notes, Web UI guidance, and docs navigation updates.
|
Reviewer note:
|
|
Thanks for the PR. I reviewed it carefully. The overall direction is good, especially the actor profile CLI surface. That part has clear product value because it exposes profile functionality that already exists in the daemon / Web / MCP layers, instead of introducing a new core mechanism. In other words, it What I do not love is the packaging of the PR as a whole. Right now it bundles together:
That makes the PR much larger than it needs to be and mixes different review concerns together. The code direction is reasonable, but the total surface area is too broad for me to want to merge it as-is. My recommendation would be:
I also checked the core CLI/profile test set on the PR branch, and the focused tests passed, so my concern is not that the main feature is unsound. The concern is mainly scope control and keeping the mainline clean. So my view is:
|
Summary
cccc actor profileCLI surface and linkage coverageAdd web and daemon version badgescommitTest Plan
/Users/glennxu/workspace/minion/cccc/.venv/bin/python -m pytest -q tests/test_cli_actor_secrets_commands.py tests/test_actor_private_env.py tests/test_cli_actor_profile_commands.py tests/test_cli_actor_profile_linkage.py tests/test_cli_actor_daemon_error_preservation.py tests/test_cli_reference_parity.py tests/test_docs_profile_cli_guides.pygit diff --check