Skip to content

feat(cli): add actor profile surfaces and glossary docs#64

Open
go-maple wants to merge 7 commits intoChesterRa:mainfrom
go-maple:feature/actor-profile-glossary-docs-clean
Open

feat(cli): add actor profile surfaces and glossary docs#64
go-maple wants to merge 7 commits intoChesterRa:mainfrom
go-maple:feature/actor-profile-glossary-docs-clean

Conversation

@go-maple
Copy link

Summary

  • add the cccc actor profile CLI surface and linkage coverage
  • align glossary, CLI, lifecycle, resume, and handover docs around the profile/runtime terminology
  • supersede PR feat(cli): add actor profile surfaces and glossary docs #63 with a clean branch that excludes the unrelated Add web and daemon version badges commit

Test Plan

  • /Users/glennxu/workspace/minion/cccc/.venv/bin/python -m pytest -q tests/test_cli_actor_secrets_commands.py tests/test_actor_private_env.py tests/test_cli_actor_profile_commands.py tests/test_cli_actor_profile_linkage.py tests/test_cli_actor_daemon_error_preservation.py tests/test_cli_reference_parity.py tests/test_docs_profile_cli_guides.py
  • git diff --check

@go-maple
Copy link
Author

Reviewer note:

@ChesterRa
Copy link
Owner

Thanks for the PR. I reviewed it carefully.

The overall direction is good, especially the actor profile CLI surface. That part has clear product value because it exposes profile functionality that already exists in the daemon / Web / MCP layers, instead of introducing a new core mechanism. In other words, it
closes a real usability gap.

What I do not love is the packaging of the PR as a whole. Right now it bundles together:

  • a high-value CLI feature
  • a large amount of glossary / positioning / workflow documentation
  • additional resume / session documentation that expands the semantic scope quite a bit

That makes the PR much larger than it needs to be and mixes different review concerns together. The code direction is reasonable, but the total surface area is too broad for me to want to merge it as-is.

My recommendation would be:

  1. Keep the core actor profile CLI command surface.
  2. Keep the focused tests that validate CLI behavior and daemon error preservation.
  3. If needed, keep only the minimal CLI reference docs required for the new commands.
  4. Split the larger glossary / positioning / resume documentation into separate follow-up PRs.

I also checked the core CLI/profile test set on the PR branch, and the focused tests passed, so my concern is not that the main feature is unsound. The concern is mainly scope control and keeping the mainline clean.

So my view is:

  • direction: yes
  • merge this whole PR as-is: probably no
  • extract and land the high-ROI CLI/profile part first: yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants