Fix shared object on x86-64 Linux having executable stack ELF flag enabled #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move harvester CI into its own workflow
Contributor
Author
|
Squash-merge only, please |
emlowe
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our older blake3 assembly files did not specify disabling of executable stack when using GCC which was now causing build issues on Arch linux.
Fixed via https://github.com/BLAKE3-team/BLAKE3/blob/adbf07d/c/blake3_avx2_x86-64_unix.S#L2
Isolated CI to only rebuild x86-64 Linux for this purpose as we don't want to mutate anything else unnecessarily as we move over to PoS2.