Skip to content

Fix(skill): Standardize UTF-8 encoding and parser output unpacking#46

Merged
joe32140 merged 1 commit intoChicagoHAI:mainfrom
ruishizou:main
Mar 20, 2026
Merged

Fix(skill): Standardize UTF-8 encoding and parser output unpacking#46
joe32140 merged 1 commit intoChicagoHAI:mainfrom
ruishizou:main

Conversation

@ruishizou
Copy link
Copy Markdown
Contributor

Summary

  • Add encoding="utf-8" in skills wherever applicable
  • Resolve only 2 values of the parser (when some return 3)

Scope of change

All scripts within the skill/scripts folder

Validation

  • pytest tests/ successful
  • /openaireview <arXiv paper link> in Claude code (on Windows cmd) without error

- Support >2 return value in the parser
- Strictly use utf-8 encoding for Windows users
@joe32140
Copy link
Copy Markdown
Contributor

Thanks @ruishizou for the fix! The UTF-8 encoding changes are spot on for Windows compatibility, and the parser unpacking fix is the right call. I applied one additional patch on top — overall_path.read_text() in save_viz_json.py was the only remaining call missing the encoding. Merging now!

@joe32140 joe32140 merged commit 6598a1c into ChicagoHAI:main Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants