Create axios instance to perform API calls#69
Merged
sathyanarayanan-v merged 2 commits intoChicoState:mainfrom Mar 29, 2023
sathyanarayanan-v:create-axios-instance
Merged
Create axios instance to perform API calls#69sathyanarayanan-v merged 2 commits intoChicoState:mainfrom sathyanarayanan-v:create-axios-instance
sathyanarayanan-v merged 2 commits intoChicoState:mainfrom
sathyanarayanan-v:create-axios-instance
Conversation
xl26
previously approved these changes
Mar 23, 2023
Contributor
Author
|
@prestonmasseyblake and @AbhinavReddy-Dev can you review this? |
AbhinavReddy-Dev
approved these changes
Mar 28, 2023
Contributor
There was a problem hiding this comment.
I personally haven't implemented this version of axios, but it looks like a cleaner way to attach the Auth token to every request.
| }, | ||
| "dependencies": { | ||
| "@types/passport": "^1.0.12", | ||
| "axios": "^1.3.4", |
Contributor
There was a problem hiding this comment.
I don't think we need an axios in this directory.
xl26
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Axiosdoes it out of the box using request interceptorAssumption made
token@SANDESHSOBARAD