Skip to content

Fix #6283 persisted-query hash-only websocket subscriptions#9246

Merged
michaelstaib merged 5 commits intomainfrom
mst/issue-6283
Mar 5, 2026
Merged

Fix #6283 persisted-query hash-only websocket subscriptions#9246
michaelstaib merged 5 commits intomainfrom
mst/issue-6283

Conversation

@michaelstaib
Copy link
Member

@michaelstaib michaelstaib commented Feb 27, 2026

Fixes #6283

  • fix graphql-transport-ws subscribe payload parsing to include the schema IDocumentCache and IDocumentHashProvider
  • this allows hash-only persisted operation payloads (extensions.persistedQuery) to be parsed into a request document id
  • add a regression test that sends a websocket subscribe message with only persisted-query extensions (no query) and verifies subscription data is received

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Fusion Gateway Performance Results

Progress: 0/6 benchmarks completed — this report updates as each job finishes.

Simple Composite Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Deep Recursion Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Variable Batching Throughput

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Runner 1 = benchmarking-1

Run 22708142275 • Commit f13f666 • Thu, 05 Mar 2026 08:00:45 GMT

@michaelstaib michaelstaib added the 🔍 investigate Indicates that an issue or pull request needs more information. label Mar 2, 2026
@michaelstaib michaelstaib merged commit 73306af into main Mar 5, 2026
124 of 132 checks passed
@michaelstaib michaelstaib deleted the mst/issue-6283 branch March 5, 2026 08:40
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6a3b7a3) to head (e53e7c8).
⚠️ Report is 881 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #9246       +/-   ##
==========================================
- Coverage   74.16%       0   -74.17%     
==========================================
  Files        2677       0     -2677     
  Lines      140790       0   -140790     
  Branches    16371       0    -16371     
==========================================
- Hits       104421       0   -104421     
+ Misses      30774       0    -30774     
+ Partials     5595       0     -5595     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌶️ hot chocolate 🔍 investigate Indicates that an issue or pull request needs more information.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persisted Queries with WebSocket fail initially

1 participant